Skip to content

ROX-24530: let Konflux images expire after 13w#13757

Merged
tommartensen merged 2 commits intomasterfrom
tm/ROX-24530-expire-konflux-images-13w
Jan 9, 2025
Merged

ROX-24530: let Konflux images expire after 13w#13757
tommartensen merged 2 commits intomasterfrom
tm/ROX-24530-expire-konflux-images-13w

Conversation

@tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Jan 9, 2025 •
edited
Loading

Description

Context: https://issues.redhat.com/browse/ROX-24530

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. Finding central-db image built on Konflux: quay.io/rhacs-eng/central-db:4.7.x-385-g4ddf2f0459-fast
  2. docker create --name expiration-check quay.io/rhacs-eng/central-db:4.7.x-385-g4ddf2f0459-fast
  3. docker inspect expiration-check | jq -r '.[0].Config.Labels["quay.expires-after"]' -> 13w

@tommartensen tommartensen self-assigned this Jan 9, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tommartensen tommartensen marked this pull request as ready for review January 9, 2025 09:03
@tommartensen tommartensen requested a review from a team as a code owner January 9, 2025 09:03
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 9, 2025 •
edited
Loading

Images are ready for the commit at 67550a9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-386-g67550a950c.

This was referenced Jan 9, 2025
Merged
Merged
Merged
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2025 •
edited
Loading

@tommartensen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-sensor-integration-tests 67550a9 link false /test gke-sensor-integration-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests 67550a9 link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-17-nongroovy-e2e-tests 67550a9 link false /test ocp-4-17-nongroovy-e2e-tests
ci/prow/gke-upgrade-tests 67550a9 link false /test gke-upgrade-tests
ci/prow/gke-qa-e2e-tests 67550a9 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@msugakov msugakov added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Jan 9, 2025
@tommartensen tommartensen enabled auto-merge (squash) January 9, 2025 13:47
@tommartensen
Copy link
Contributor Author

tommartensen commented Jan 9, 2025

/test gke-nongroovy-e2e-tests

@tommartensen tommartensen merged commit a9eb60a into master Jan 9, 2025
@tommartensen tommartensen deleted the tm/ROX-24530-expire-konflux-images-13w branch January 9, 2025 15:04
tommartensen added a commit to stackrox/operator-index that referenced this pull request Jan 13, 2025
@tommartensen
ROX-25430: let Konflux images expire after 13w (#42)
6eecb63 
Context: 
* https://issues.redhat.com/browse/ROX-24530
* stackrox/stackrox#13757
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
@tommartensen @ajheflin
ROX-24530: let Konflux images expire after 13w (#13757)
8c3610d
msugakov pushed a commit that referenced this pull request Jun 25, 2025
@tommartensen @msugakov
ROX-24530: let Konflux images expire after 13w (#13757)
fbff91e
msugakov pushed a commit that referenced this pull request Jun 25, 2025
@tommartensen @msugakov
ROX-24530: let Konflux images expire after 13w (#13757)
3000bc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msugakov msugakov msugakov approved these changes

Assignees

@tommartensen tommartensen

Labels

backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommartensen @rhacs-bot @msugakov