Skip to content

ROX-22250: Switch to sanitizing version of determine-image-tag#13995

Merged
msugakov merged 2 commits intomasterfrom
misha/ROX-22250-sanitize-version-konflux
Jan 30, 2025
Merged

ROX-22250: Switch to sanitizing version of determine-image-tag#13995
msugakov merged 2 commits intomasterfrom
misha/ROX-22250-sanitize-version-konflux

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Jan 27, 2025 •
edited
Loading

Description

Using task from stackrox/konflux-tasks#30.
Main image tag becomes the same as operator image tag and so we can eliminate some of the extra tasks and discrepancies.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

  • All produced image tags have .0 instead of .x.

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 27, 2025 •
edited
Loading

Images are ready for the commit at d24759e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-552-gd24759e492.

@codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.89%. Comparing base (6243dd0) to head (d24759e).
Report is 26 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #13995   +/-   ##
=======================================
  Coverage   48.88%   48.89%           
=======================================
  Files        2496     2499    +3     
  Lines      180746   180796   +50     
=======================================
+ Hits        88359    88400   +41     
- Misses      85370    85375    +5     
- Partials     7017     7021    +4
Flag Coverage Δ
go-unit-tests 48.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msugakov msugakov force-pushed the misha/ROX-22250-sanitize-version-konflux branch 2 times, most recently from 2db1035 to 3bf4e23 Compare January 28, 2025 11:36
@msugakov msugakov force-pushed the misha/ROX-22250-sanitize-version-konflux branch from 3bf4e23 to 1ca8d0d Compare January 28, 2025 11:54
@msugakov msugakov mentioned this pull request Jan 28, 2025
Merged
@msugakov msugakov added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Jan 28, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 28, 2025

/retest scanner-v4-on-push

@msugakov
Copy link
Contributor Author

msugakov commented Jan 28, 2025

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 28, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jan 28, 2025
@msugakov msugakov marked this pull request as ready for review January 28, 2025 18:26
@msugakov msugakov requested a review from a team as a code owner January 28, 2025 18:26
@msugakov msugakov requested a review from tommartensen January 28, 2025 18:26
tommartensen
tommartensen reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@tommartensen tommartensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the switch to latest tasks. Ping for re-review once done.

@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest central-db-on-push

@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest scanner-v4-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest central-db-on-push

@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest scanner-v4-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest scanner-v4-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

The amount of required /retet-s is unhealthy. Nevertheless, I verified that all pipelines produce .0 in tags.

@msugakov msugakov requested a review from tommartensen January 29, 2025 18:27
@msugakov msugakov merged commit 99412aa into master Jan 30, 2025
91 of 99 checks passed
@msugakov msugakov deleted the misha/ROX-22250-sanitize-version-konflux branch January 30, 2025 09:03
shireenf-ibm pushed a commit to shireenf-ibm/stackrox that referenced this pull request Feb 10, 2025
@msugakov @shireenf-ibm
ROX-22250: Switch to sanitizing version of determine-image-tag (stack…
2bf1bfa 
…rox#13995)
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
@msugakov @ajheflin
ROX-22250: Switch to sanitizing version of determine-image-tag (#13995)
5087fd1
msugakov added a commit that referenced this pull request Jun 26, 2025
@msugakov
ROX-22250: Switch to sanitizing version of determine-image-tag (#13995)
df31d1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommartensen tommartensen tommartensen approved these changes

Assignees

No one assigned

Labels

backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msugakov @rhacs-bot @tommartensen