Skip to content

ROX-27764: Stop providing PipelineRun in AppStudio's label#14011

Merged
msugakov merged 2 commits intomasterfrom
misha/ROX-27764-try-reenable-default-snapshot-konflux
Jan 30, 2025
Merged

ROX-27764: Stop providing PipelineRun in AppStudio's label#14011
msugakov merged 2 commits intomasterfrom
misha/ROX-27764-try-reenable-default-snapshot-konflux

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Jan 28, 2025 •
edited
Loading

Description

from stackrox/konflux-tasks#31

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

Manually verified operator-bundle pipeline and the snapshots.

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 28, 2025 •
edited
Loading

Images are ready for the commit at 88dc93b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-578-g88dc93b163.

@msugakov
Copy link
Contributor Author

msugakov commented Jan 28, 2025

/retest scanner-v4-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 28, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 28, 2025

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 28, 2025
@codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.90%. Comparing base (99412aa) to head (88dc93b).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14011   +/-   ##
=======================================
  Coverage   48.89%   48.90%           
=======================================
  Files        2499     2499           
  Lines      180796   180796           
=======================================
+ Hits        88409    88410    +1     
+ Misses      85366    85365    -1     
  Partials     7021     7021
Flag Coverage Δ
go-unit-tests 48.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msugakov
Copy link
Contributor Author

msugakov commented Jan 28, 2025 •
edited
Loading

Yes, having appstudio.openshift.io/build-pipelinerun": "" was enough to see the standard Snapshot to appear.
See https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/operator-bundle-on-push-74j7m

image

Our custom Snapshot is still openable in UI https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/snapshots/acs-4-7-x-551-g476c8311c1-fast-20250128t190622z, has the relevant commit linked to it and has EC execution.

image

@msugakov msugakov changed the title ROX-27767: Use snapshot task version that makes no link to the pipelinerun ROX-27764: Use snapshot task version that makes no link to the pipelinerun Jan 29, 2025
@msugakov msugakov force-pushed the misha/ROX-27764-try-reenable-default-snapshot-konflux branch from 476c831 to 16817b6 Compare January 29, 2025 16:46
@msugakov msugakov changed the title ROX-27764: Use snapshot task version that makes no link to the pipelinerun ROX-27764: Stop providing PipelineRun in AppStudio's label Jan 29, 2025
@msugakov msugakov mentioned this pull request Jan 29, 2025
Merged
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest roxctl-on-push

@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest scanner-v4-db-on-push

@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest scanner-v4-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest scanner-v4-db-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025

/retest main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 29, 2025
@msugakov
Copy link
Contributor Author

msugakov commented Jan 29, 2025 •
edited
Loading

For the recent round.

  1. The standard snapshot is still created.
  2. Our custom one loads in UI.
  3. Our custom one has expected labels
  labels:
    appstudio.openshift.io/build-pipelinerun: ""
    created-by-pipelinerun: operator-bundle-on-push-6lpql
  name: acs-4-7-x-570-g16817b6f45-fast-20250129t182954z

@msugakov msugakov marked this pull request as ready for review January 29, 2025 18:46
@msugakov msugakov requested a review from a team as a code owner January 29, 2025 18:46
@msugakov msugakov requested a review from tommartensen January 29, 2025 18:46
@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2025

@msugakov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-17-nongroovy-e2e-tests 16817b6 link false /test ocp-4-17-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tommartensen
tommartensen approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@tommartensen tommartensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided you update the task digest before merging.

@msugakov msugakov force-pushed the misha/ROX-27764-try-reenable-default-snapshot-konflux branch from 16817b6 to 88dc93b Compare January 30, 2025 09:11
@msugakov
Copy link
Contributor Author

msugakov commented Jan 30, 2025

I won't put the backport-... label here because the ultimate change is nothing different than tasks update. We'll get the same with Renovate or can easily do this manually. Including this PR to backporting will only increase the number of conflicts we'll have to deal with.

@msugakov msugakov merged commit fc5b35e into master Jan 30, 2025
91 of 99 checks passed
@msugakov msugakov deleted the misha/ROX-27764-try-reenable-default-snapshot-konflux branch January 30, 2025 11:27
shireenf-ibm pushed a commit to shireenf-ibm/stackrox that referenced this pull request Feb 10, 2025
@msugakov @shireenf-ibm
ROX-27764: Stop providing PipelineRun in AppStudio's label (stackrox#…
6a3b639 
…14011)
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
@msugakov @ajheflin
ROX-27764: Stop providing PipelineRun in AppStudio's label (#14011)
8f31638
msugakov added a commit that referenced this pull request Jun 26, 2025
@msugakov
ROX-27764: Stop providing PipelineRun in AppStudio's label (#14011)
472be94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommartensen tommartensen tommartensen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msugakov @rhacs-bot @tommartensen