build: Switch Konflux UI builds from NodeJS 18 to 20#14086
Conversation
|
Images are ready for the commit at bdab180. To use with deploy scripts, first |
|
|
pedrottimark
left a comment
There was a problem hiding this comment.
Super, thank you very much. As far as I can read CI results, relevant steps passed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14086 +/- ##
=======================================
Coverage 48.92% 48.92%
=======================================
Files 2500 2500
Lines 180852 180852
=======================================
+ Hits 88474 88480 +6
+ Misses 85357 85352 -5
+ Partials 7021 7020 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@msugakov: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
See https://redhat-internal.slack.com/archives/C7ERNFL0M/p1738574728275579
Mark reports that his local builds are in fact powered by 20. GHA builds also use 20.
Unfortunately, there's no 22 in the catalog for ubi8 base (see here), therefore setting the builder stage to 20.
User-facing documentation
Testing and quality
Automated testing
No change.
How I validated my change
I'm only going to check that UI build completes successfully. I'm not going to test the UI functioning as part of this change.
Per the investigation in the Slack thread, UI is already built and tested with 20 on GHA.