Skip to content

ROX-27831: set image expiration based on event type and target branch#14192

Merged
tommartensen merged 10 commits intomasterfrom
tm/ROX-27831konflux-image-expiration-custom-task
Feb 17, 2025
Merged

ROX-27831: set image expiration based on event type and target branch#14192
tommartensen merged 10 commits intomasterfrom
tm/ROX-27831konflux-image-expiration-custom-task

Conversation

@tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Feb 10, 2025

Description

See stackrox/konflux-tasks#37

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

See stackrox/konflux-tasks#37 and passing builds here.

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 10, 2025

Images are ready for the commit at 5ee054e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-24-g5ee054eefb.

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.08%. Comparing base (ea89b47) to head (5ee054e).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14192   +/-   ##
=======================================
  Coverage   49.07%   49.08%           
=======================================
  Files        2514     2514           
  Lines      182769   182769           
=======================================
+ Hits        89702    89704    +2     
+ Misses      85947    85945    -2     
  Partials     7120     7120           
Flag Coverage Δ
go-unit-tests 49.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommartensen
Copy link
Contributor Author

/test roxctl-on-push

@openshift-ci

This comment was marked as off-topic.

@tommartensen
Copy link
Contributor Author

/test retag-collector-slim

@openshift-ci

This comment was marked as off-topic.

@tommartensen
Copy link
Contributor Author

/test operator-bundle-on-push

@openshift-ci

This comment was marked as off-topic.

@tommartensen tommartensen force-pushed the tm/ROX-27831konflux-image-expiration-custom-task branch from ef6da46 to 5ee054e Compare February 14, 2025 09:50
@tommartensen tommartensen marked this pull request as ready for review February 14, 2025 11:49
@tommartensen tommartensen requested a review from a team as a code owner February 14, 2025 11:49
@tommartensen tommartensen enabled auto-merge (squash) February 14, 2025 11:49
@tommartensen
Copy link
Contributor Author

/test gke-nongroovy-e2e-tests

@tommartensen tommartensen merged commit 177bdd2 into master Feb 17, 2025
102 of 109 checks passed
@tommartensen tommartensen deleted the tm/ROX-27831konflux-image-expiration-custom-task branch February 17, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants