Skip to content

chore: Bump pytest version (2nd)#14243

Closed
mclasmeier wants to merge 5 commits intomasterfrom
mc/operator-bundle-helpers-version-update-2
Closed

chore: Bump pytest version (2nd)#14243
mclasmeier wants to merge 5 commits intomasterfrom
mc/operator-bundle-helpers-version-update-2

Conversation

@mclasmeier
Copy link
Contributor

@mclasmeier mclasmeier commented Feb 12, 2025

Description

Just a pytest version bump in the requirements-gha.txt file and removal of pytest from the requirements.in file plus regeneration of files according to the README.

Description of a nix environment is provided, use nix-shell to enter it.
Within this environment you can execute e.g. the pip-compile commands.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@mclasmeier mclasmeier requested a review from a team as a code owner February 12, 2025 13:41
@mclasmeier mclasmeier requested review from porridge and tommartensen and removed request for a team February 12, 2025 13:41
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 12, 2025

Images are ready for the commit at 02de7e7.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-728-g02de7e7277.

1 similar comment
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 12, 2025

Images are ready for the commit at 02de7e7.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-728-g02de7e7277.

@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2025

@mclasmeier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-operator-e2e-tests 02de7e7 link false /test gke-operator-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests 02de7e7 link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests 02de7e7 link false /test ocp-4-12-operator-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests 02de7e7 link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-17-qa-e2e-tests 02de7e7 link false /test ocp-4-17-qa-e2e-tests
ci/prow/ocp-4-17-nongroovy-e2e-tests 02de7e7 link false /test ocp-4-17-nongroovy-e2e-tests
ci/prow/ocp-4-17-operator-e2e-tests 02de7e7 link false /test ocp-4-17-operator-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mclasmeier mclasmeier closed this Feb 17, 2025
@porridge
Copy link
Contributor

porridge commented Feb 17, 2025

Doesn't seem to work

ERROR: Could not find a version that satisfies the requirement pytest==7.4.3 (from versions: 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.1.0, 2.1.1, 2.1.2, 2.1.3, 2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.2.4, 2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.4.0, 2.4.1, 2.4.2, 2.5.0, 2.5.1, 2.5.2, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.6.4, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0, 2.8.1, 2.8.2, 2.8.3, 2.8.4, 2.8.5, 2.8.6, 2.8.7, 2.9.0, 2.9.1, 2.9.2, 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.0.6, 3.0.7, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5, 3.3.0, 3.3.1, 3.3.2, 3.4.0, 3.4.1, 3.4.2, 3.5.0, 3.5.1, 3.6.0, 3.6.1, 3.6.2, 3.6.3, 3.6.4, 3.7.0, 3.7.1, 3.7.2, 3.7.3, 3.7.4, 3.8.0, 3.8.1, 3.8.2, 3.9.1, 3.9.2, 3.9.3, 3.10.0, 3.10.1, 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0, 4.2.1, 4.3.0, 4.3.1, 4.4.0, 4.4.1, 4.4.2, 4.5.0, 4.6.0, 4.6.1, 4.6.2, 4.6.3, 4.6.4, 4.6.5, 4.6.6, 4.6.7, 4.6.8, 4.6.9, 4.6.10, 4.6.11, 5.0.0, 5.0.1, 5.1.0, 5.1.1, 5.1.2, 5.1.3, 5.2.0, 5.2.1, 5.2.2, 5.2.3, 5.2.4, 5.3.0, 5.3.1, 5.3.2, 5.3.3, 5.3.4, 5.3.5, 5.4.0, 5.4.1, 5.4.2, 5.4.3, 6.0.0rc1, 6.0.0, 6.0.1, 6.0.2, 6.1.0, 6.1.1, 6.1.2, 6.2.0, 6.2.1, 6.2.2, 6.2.3, 6.2.4, 6.2.5, 7.0.0rc1, 7.0.0, 7.0.1)
ERROR: No matching distribution found for pytest==7.4.3
make: *** [Makefile:419: bundle] Error 1

@porridge porridge reopened this Feb 17, 2025
@mclasmeier
Copy link
Contributor Author

mclasmeier commented Feb 17, 2025

@porridge We plan to merge a different PR for this. But out of curiosity, could you elaborate on what you have tried exactly to trigger this error?

@codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.04%. Comparing base (b539fc8) to head (02de7e7).
Report is 48 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #14243      +/-   ##
==========================================
- Coverage   49.08%   49.04%   -0.04%     
==========================================
  Files        2512     2514       +2     
  Lines      182676   182871     +195     
==========================================
+ Hits        89666    89698      +32     
- Misses      85890    86051     +161     
- Partials     7120     7122       +2
Flag Coverage Δ
go-unit-tests 49.04% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@porridge
Copy link
Contributor

porridge commented Feb 17, 2025

@porridge We plan to merge a different PR for this. But out of curiosity, could you elaborate on what you have tried exactly to trigger this error?

I just copy/pasted this from CI (GHA).

@mclasmeier
Copy link
Contributor Author

mclasmeier commented Feb 17, 2025

This PR is superseded by #14257 (review). It is more conservative wrt version bumps, hence the hope is that GHA will also be happy.

@mclasmeier mclasmeier closed this Feb 17, 2025
@mclasmeier mclasmeier deleted the mc/operator-bundle-helpers-version-update-2 branch September 10, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porridge porridge Awaiting requested review from porridge porridge is a code owner automatically assigned from stackrox/install

@tommartensen tommartensen Awaiting requested review from tommartensen

Assignees

No one assigned

Labels

area/operator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mclasmeier @rhacs-bot @porridge