ROX-13493: Add admission controller support for Scale subresource#14296
ROX-13493: Add admission controller support for Scale subresource#14296
Conversation
|
Images are ready for the commit at 6f4b7e6. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14296 +/- ##
==========================================
- Coverage 49.06% 49.04% -0.02%
==========================================
Files 2514 2515 +1
Lines 182847 182869 +22
==========================================
- Hits 89707 89684 -23
- Misses 86020 86063 +43
- Partials 7120 7122 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
89aa6d0 to
8d562b1
Compare
f90f303 to
2c5448c
Compare
161cf91 to
212b19b
Compare
212b19b to
0b93d14
Compare
|
/test ocp-4-12-nongroovy-e2e-tests |
|
@clickboo: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dashrews78
left a comment
There was a problem hiding this comment.
Looks OK based on my knowledge
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-4.6 release-4.6
# Navigate to the new working tree
cd .worktrees/backport-release-4.6
# Create a new branch
git switch --create backport-14296-to-release-4.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f548f9ad152c3b742f412a0c3d1df781189be48
# Push it to GitHub
git push --set-upstream origin backport-14296-to-release-4.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-4.6Then, create a pull request where the |
Description
There exist 3 ways of scaling a deployment in k8s/Openshift:
replicasproperty.kubectl scaleoroc scaleon the deployment.v1/autoscaling scalesubresource (Openshift console uses this)The admission controller has existing support to run policy detection and enforcement on 1. and 2. above. However, it was missing support for the
scalesubresource. This PR adds that support.While I was at it, I also fixed a small product branding miss in the output messages/response of the admission controller when the request is denied.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Testing on an Openshift cluster with admission controller enabled for 3 scenarios:
oc scaleto scale deployment replicas on the same deployment