Skip to content

ROX-27053: Fix subjects handling for user and group kind [backport]#14414

Merged
janisz merged 2 commits intorelease-4.5from
backport-13410-to-release-4.5
Feb 28, 2025
Merged

ROX-27053: Fix subjects handling for user and group kind [backport]#14414
janisz merged 2 commits intorelease-4.5from
backport-13410-to-release-4.5

Conversation

@rhacs-bot
Copy link
Contributor

Backport 367a7ff from #13410.

@github-actions github-actions bot added area/central backport PR to backport changes from master to release branch labels Feb 26, 2025
@janisz janisz changed the title [Backport release-4.5] ROX-27053: Fix subjects handling for user and group kind ROX-27053: Fix subjects handling for user and group kind [backport] Feb 26, 2025
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@rhacs-bot
Copy link
Contributor Author

Images are ready for the commit at cfc4a3f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.5.6-2-gcfc4a3f9aa.

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.07%. Comparing base (8c7953a) to head (cfc4a3f).
Report is 1 commits behind head on release-4.5.

Files with missing lines Patch % Lines
central/compliance/checks/common/rbac.go 0.00% 3 Missing ⚠️
pkg/k8srbac/subjects.go 88.23% 2 Missing ⚠️
central/rbac/service/get_subject.go 0.00% 1 Missing ⚠️
pkg/k8srbac/evaluator_impl.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-4.5   #14414      +/-   ##
===============================================
- Coverage        48.08%   48.07%   -0.02%     
===============================================
  Files             2390     2391       +1     
  Lines           171174   171278     +104     
===============================================
+ Hits             82316    82334      +18     
- Misses           82215    82301      +86     
  Partials          6643     6643              
Flag Coverage Δ
go-unit-tests 48.07% <72.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janisz
Copy link
Contributor

janisz commented Feb 27, 2025

/retest

@janisz janisz added the auto-retest PRs with this label will be automatically retested if prow checks fails label Feb 27, 2025
@rhacs-bot
Copy link
Contributor Author

/retest

@janisz janisz merged commit 44e227d into release-4.5 Feb 28, 2025
82 checks passed
@janisz janisz deleted the backport-13410-to-release-4.5 branch February 28, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/central auto-retest PRs with this label will be automatically retested if prow checks fails backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants