ROX-28258: Fix segfault when calling deactivate on stopped TLS issuer#14429
Merged
vladbologa merged 1 commit intomasterfrom Feb 27, 2025
Merged
ROX-28258: Fix segfault when calling deactivate on stopped TLS issuer#14429vladbologa merged 1 commit intomasterfrom
vladbologa merged 1 commit intomasterfrom
Conversation
lvalerom
approved these changes
Feb 27, 2025
Contributor
lvalerom
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Contributor
|
Images are ready for the commit at b2564d6. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14429 +/- ##
=======================================
Coverage 49.04% 49.04%
=======================================
Files 2521 2521
Lines 183398 183398
=======================================
+ Hits 89941 89942 +1
- Misses 86336 86337 +1
+ Partials 7121 7119 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#13596 introduced a segmentation fault, when calling deactivate() on a TLS issuer that is not started.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Added a unit test that is crashing without the change.