Skip to content

ROX-28259: Refactor and test connection enrichment in Sensor#14464

Closed
lvalerom wants to merge 10 commits intomasterfrom
lvm/rox-28259-investigation
Closed

ROX-28259: Refactor and test connection enrichment in Sensor#14464
lvalerom wants to merge 10 commits intomasterfrom
lvm/rox-28259-investigation

Conversation

@lvalerom
Copy link
Contributor

@lvalerom lvalerom commented Mar 3, 2025 •
edited by vikin91
Loading

Description

https://issues.redhat.com/browse/ROX-28259

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 3, 2025 •
edited
Loading

Images are ready for the commit at 8566e87.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-127-g8566e87944.

@codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.42%. Comparing base (2b0a479) to head (8566e87).
Report is 470 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #14464       +/-   ##
===========================================
+ Coverage   49.04%   49.42%    +0.37%     
===========================================
  Files        2521      720     -1801     
  Lines      183400    71769   -111631     
===========================================
- Hits        89943    35469    -54474     
+ Misses      86337    33094    -53243     
+ Partials     7120     3206     -3914
Flag Coverage Δ
go-unit-tests 49.42% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91 vikin91 changed the title DO-NOT-MERGE: last seen timestamp investigation ROX-28259: Refactor and test connection enrichment in Sensor Mar 6, 2025
@vikin91
Copy link
Contributor

vikin91 commented Apr 30, 2025

@lvalerom can we close this PR?
I ported all of the useful code from it to #14538 (merged) and #15076 (which is still WIP).

@lvalerom
Copy link
Contributor Author

lvalerom commented Apr 30, 2025

@lvalerom can we close this PR?
I ported all of the useful code from it to #14538 (merged) and #15076 (which is still WIP).

Sure! I'll close it 👍

@lvalerom lvalerom closed this Apr 30, 2025
@vikin91 vikin91 deleted the lvm/rox-28259-investigation branch September 10, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/sensor do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lvalerom @rhacs-bot @vikin91