-
Notifications
You must be signed in to change notification settings - Fork 171
ROX-28479: Add external IPs to fake workload generation #14574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoukoVirtanen
merged 13 commits into
master
from
jv-ROX-28479-add-external-ips-to-fake-workload-generation
Mar 25, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7324607
X-Smart-Branch-Parent: master
JoukoVirtanen e406412
Fake workload generation now includes external IPs
JoukoVirtanen 42dce30
Getting external IPs from a range. Guaranteeing that there are 1000 I…
JoukoVirtanen 8436aaa
Empty commit
JoukoVirtanen b090720
Empty commit
JoukoVirtanen 2f23c77
Empty commit
JoukoVirtanen 37acb25
Apply suggestions from code review
JoukoVirtanen 6be2e4e
External IPs should not include loop back address. Listening endpoint…
JoukoVirtanen 80619a9
Changed range where external IPs are generated. Added a test
JoukoVirtanen 9b80718
Generate external IPs sequentially
JoukoVirtanen 6d6b24e
Fixed style
JoukoVirtanen 56d9b7a
Improved testing
JoukoVirtanen 68301c6
Refactor to reduce code duplication and improve logging
JoukoVirtanen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package fake | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stackrox/rox/pkg/net" | ||
| "github.com/stretchr/testify/suite" | ||
| ) | ||
|
|
||
| type flowsSuite struct { | ||
| suite.Suite | ||
| } | ||
|
|
||
| func TestFlowsSuite(t *testing.T) { | ||
| suite.Run(t, new(flowsSuite)) | ||
| } | ||
|
|
||
| func (s *flowsSuite) TestGetRandomInternalExternalIP() { | ||
| var w WorkloadManager | ||
|
|
||
| _, _, ok := w.getRandomSrcDst() | ||
| s.False(ok) | ||
|
|
||
| for range 1000 { | ||
| generateAndAddIPToPool() | ||
| } | ||
|
|
||
| generateExternalIPPool() | ||
|
|
||
| for range 1000 { | ||
| ip, internal, ok := w.getRandomInternalExternalIP() | ||
| s.True(ok) | ||
| s.Equal(internal, !net.ParseIP(ip).IsPublic()) | ||
| } | ||
|
|
||
| for range 1000 { | ||
| src, dst, ok := w.getRandomSrcDst() | ||
| // At least one has to be internal | ||
| s.True(!net.ParseIP(src).IsPublic() || !net.ParseIP(dst).IsPublic()) | ||
| s.True(ok) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.