Closed
Conversation
|
Skipping CI for Draft Pull Request. |
c253002 to
23126b6
Compare
Contributor
|
Images are ready for the commit at 83a63ac. To use with deploy scripts, first |
38b0c0e to
a65a27c
Compare
23126b6 to
799cec1
Compare
janisz
reviewed
Apr 3, 2025
| @@ -84,6 +84,7 @@ type Store interface { | |||
| Get(ctx context.Context, {{template "paramList" $pks}}) (*storeType, bool, error) | |||
| {{- if .SearchCategory }} | |||
| GetByQuery(ctx context.Context, query *v1.Query) ([]*storeType, error) | |||
Contributor
There was a problem hiding this comment.
Suggested change
| GetByQuery(ctx context.Context, query *v1.Query) ([]*storeType, error) | |
| // Deprecated: Use GetByQueryFn instead | |
| GetByQuery(ctx context.Context, query *v1.Query) ([]*storeType, error) |
Add GetByQueryFn
799cec1 to
83a63ac
Compare
7 tasks
This was referenced Apr 29, 2025
Contributor
Author
|
PR is obsolete, and implementation is done within other PRs. Tnx @janisz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding the
GetByQueryFnfunction to storage. This way of handling rows returned by DB helps with:During the evaluation of improvements, I have done the following testing:
For 2. I did the following:
runtime.ReadMemStats().This test shows the following results (5 executions on each version):
OLD
NEW
Memory levels are way better with callbacks. The memory level was 70% of the initial code.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI pipeline and local bench testing