chore(tests): remove SkipIfPostgresEnabled#14749
Conversation
|
Images are ready for the commit at c0292c5. To use with deploy scripts, first |
dashrews78
left a comment
There was a problem hiding this comment.
Before removing datastore_impl_test.go please verify test parity with datastore_impl_postgres_test.go and either write a ticket or do follow on work to deal with any tests we should have in the postgres version. We found a while back that when the old cluster datastore tests were removed a lot of test coverage was removed and we recently added that back in. It would be nice to quantify that now vs accidentally find it later.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14749 +/- ##
==========================================
+ Coverage 48.95% 49.00% +0.05%
==========================================
Files 2550 2550
Lines 187245 187245
==========================================
+ Hits 91664 91765 +101
+ Misses 88332 88228 -104
- Partials 7249 7252 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dashrews78 I fixed tests (removed one that has comment to remove) and this lead me to find a ux bug in errors. |
|
/retest |
c690a58 to
9e32295
Compare
|
@dashrews78 @clickboo PTAL |
dashrews78
left a comment
There was a problem hiding this comment.
I think this is OK. I would prefer a sign off from @clickboo before merging though.
20fdd97 to
af43d84
Compare
|
@clickboo I rebased on master. Please take a look |
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com> # Conflicts: # central/policy/datastore/datastore_impl_test.go
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
af43d84 to
c0292c5
Compare
|
/retest |
Description
It's long time since we switch to postgres and it's time to cleanup.
SkipIfPostgresEnabledwas introduced to skip tests that will not work on postgres and run them when the feature flag is disable. Over the time it evolved to skip test always (as feature flag was always on, and eventually removed). This PR removes this functions and fixes tests or remove them when the new postgres test was added.Testing
Automated testing
How I validated my change
CI