Skip to content

chore(deps): remove unused docker-java dependency#14863

Merged
janisz merged 1 commit intomasterfrom
remove_unused_deps
Apr 3, 2025
Merged

chore(deps): remove unused docker-java dependency#14863
janisz merged 1 commit intomasterfrom
remove_unused_deps

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Apr 3, 2025

Description

The dependency was added in 037d4d4
but then the use was removed in 5e307f3
but the dependency was left and it's time to remove it.

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from a team April 3, 2025 09:08
@rhacs-bot
Copy link
Copy Markdown
Contributor

Images are ready for the commit at 402df6f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-373-g402df6f67f.

@janisz janisz changed the title chore(ci): remove unused dependency chore(deps): remove unused docker-java dependency Apr 3, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (6d5d4da) to head (402df6f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14863      +/-   ##
==========================================
+ Coverage   48.89%   49.01%   +0.11%     
==========================================
  Files        2547     2547              
  Lines      186900   186939      +39     
==========================================
+ Hits        91389    91628     +239     
+ Misses      88276    88061     -215     
- Partials     7235     7250      +15     
Flag Coverage Δ
go-unit-tests 49.01% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz janisz merged commit 695368d into master Apr 3, 2025
89 checks passed
@janisz janisz deleted the remove_unused_deps branch April 3, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants