ROX-29006: don't enforce project scope for google registries#14864
Merged
ROX-29006: don't enforce project scope for google registries#14864
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 6982118. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14864 +/- ##
=======================================
Coverage 49.21% 49.21%
=======================================
Files 2577 2577
Lines 189101 189101
=======================================
+ Hits 93068 93073 +5
+ Misses 88695 88692 -3
+ Partials 7338 7336 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ab1def5 to
61b5f19
Compare
61b5f19 to
12df960
Compare
RTann
approved these changes
Apr 4, 2025
Contributor
RTann
left a comment
There was a problem hiding this comment.
LGTM from backend perspective
3e516a4 to
dac0124
Compare
dac0124 to
cba325d
Compare
cba325d to
6982118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't enforce a project scope for google registries. The reason is that in setups with many different projects, it is cumbersome to create an integration per project. Instead, it may be more efficient to set proper access permissions on the GCP side, and then allow matching for all projects. This way a single integration may cover multiple projects.
User-facing documentation
Testing and quality
Automated testing
How I validated my change