Update merge of configureConfigController#14882
Merged
janisz merged 1 commit intoROX-15902_use_walk_in_auth_m2mfrom Apr 7, 2025
Merged
Update merge of configureConfigController#14882janisz merged 1 commit intoROX-15902_use_walk_in_auth_m2mfrom
janisz merged 1 commit intoROX-15902_use_walk_in_auth_m2mfrom
Conversation
* Remove need for `upserted` bool and second call to `configureConfigControllerAccess` * Removed need to loop over configs twice in test by removing `getTestConfig` * Made the test more precise by implementing a M2M config matcher for Kube SA
Contributor
|
Images are ready for the commit at 03a7519. To use with deploy scripts, first |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ROX-15902_use_walk_in_auth_m2m #14882 +/- ##
==================================================================
+ Coverage 48.86% 49.01% +0.15%
==================================================================
Files 2546 2546
Lines 186948 186941 -7
==================================================================
+ Hits 91348 91633 +285
+ Misses 88360 88058 -302
- Partials 7240 7250 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upsertedbool and second call toconfigureConfigControllerAccessgetTestConfig