Skip to content

chore: Add job-preamble to jobs in style.yml where missing#14952

Merged
msugakov merged 1 commit intomasterfrom
misha/add-job-preamble-to-style
Apr 11, 2025
Merged

chore: Add job-preamble to jobs in style.yml where missing#14952
msugakov merged 1 commit intomasterfrom
misha/add-job-preamble-to-style

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Apr 10, 2025 •
edited
Loading

Description

This follows up on #14922 as I've noticed the jobs I moved don't get registered in BigQuery.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change

How I validated my change

  1. CI is still green.
  2. New data is arriving.
select *
from `acs-san-stackroxci.ci_metrics.stackrox_jobs`
where pr_number=14952
and name in ('check-collector-and-scanner-images-exist', 'github-actions-lint', 'github-actions-shellcheck')

image

Summary by Sourcery

CI:

  • Add .github/actions/job-preamble step to multiple GitHub Actions workflow jobs to improve job tracking and monitoring

Summary by Sourcery

CI:

  • Add .github/actions/job-preamble step to multiple GitHub Actions workflow jobs to enable better job tracking in BigQuery

@openshift-ci
Copy link

openshift-ci bot commented Apr 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 10, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds the job-preamble action to several jobs within the style.yml GitHub Actions workflow. This change ensures that these jobs are properly registered in BigQuery for tracking and monitoring purposes. The job-preamble action is implemented by adding a new step that utilizes the .github/actions/job-preamble action with a GCP service account.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a job-preamble step to multiple jobs in the style.yml workflow.
  • Added a job-preamble step to the check-collector-and-scanner-images-exist job.
  • Added a job-preamble step to the github-actions-lint job.
  • Added a job-preamble step to the github-actions-shellcheck job.
 .github/workflows/style.yaml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@msugakov msugakov marked this pull request as ready for review April 10, 2025 17:25
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Apr 10, 2025

Images are ready for the commit at 02f3e79.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-454-g02f3e79360.

@codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.95%. Comparing base (867acc6) to head (02f3e79).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #14952      +/-   ##
==========================================
- Coverage   48.96%   48.95%   -0.01%     
==========================================
  Files        2550     2550              
  Lines      187272   187272              
==========================================
- Hits        91698    91685      -13     
- Misses      88324    88334      +10     
- Partials     7250     7253       +3
Flag Coverage Δ
go-unit-tests 48.95% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

davdhacs
davdhacs approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@msugakov msugakov changed the title core: Add job-preamble to jobs in style.yml where missing chore: Add job-preamble to jobs in style.yml where missing Apr 11, 2025
@msugakov msugakov merged commit be41b87 into master Apr 11, 2025
89 of 96 checks passed
@msugakov msugakov deleted the misha/add-job-preamble-to-style branch April 11, 2025 07:44
janisz pushed a commit that referenced this pull request Apr 14, 2025
@msugakov @janisz
chore: Add job-preamble to jobs in style.yml where missing (#14952)
59709ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davdhacs davdhacs davdhacs approved these changes

@tommartensen tommartensen Awaiting requested review from tommartensen

Assignees

No one assigned

Labels

area/ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msugakov @rhacs-bot @davdhacs