ROX-24313: Disable test "Verify two flows co-exist if ..." #15127
Merged
ROX-24313: Disable test "Verify two flows co-exist if ..." #15127
Conversation
Contributor
There was a problem hiding this comment.
Hey @vikin91 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 67346e7. To use with deploy scripts, first |
janisz
approved these changes
Apr 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15127 +/- ##
=======================================
Coverage 49.11% 49.11%
=======================================
Files 2557 2557
Lines 187839 187839
=======================================
+ Hits 92250 92255 +5
+ Misses 88312 88309 -3
+ Partials 7277 7275 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My refactor #14538 seem to have caused this test to fail more regularly (before it was only flaking). I would like to investigate this before we decide to revert the big PR.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
I haven't