Skip to content

ROX-29505: run sensor integration tests on GHA#15407

Merged
janisz merged 6 commits intomasterfrom
janisz/run_sensor_integration_test_on_gha
May 28, 2025
Merged

ROX-29505: run sensor integration tests on GHA#15407
janisz merged 6 commits intomasterfrom
janisz/run_sensor_integration_test_on_gha

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented May 22, 2025 •
edited
Loading

This PR runs sensor integration tests on GHA with kind cluster. This will replace PROW job that do the same but on GKE cluster.

Refs:

@janisz
tests: run sensor integration tests on GHA
3e417d0 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
sourcery-ai[bot]
sourcery-ai bot reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @janisz - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 22, 2025 •
edited
Loading

Images are ready for the commit at 4731ec5.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-793-g4731ec5867.

janisz added 2 commits May 22, 2025 16:02
@janisz
do not install roxctl
c166b32 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
remove container
0b6ae04 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
janisz commented May 22, 2025
View reviewed changes
@janisz janisz requested a review from a team May 22, 2025 15:18
vikin91
vikin91 reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully reviewing yet, but I noticed two things:

First is purely aesthetic:
Screenshot 2025-05-22 at 18 09 31
It looks a bit weird to group this under "Unit tests", but I think, I can live with that.

Second maybe more critical.
In the prow job history I see that there are 60 executed and passing in the green runs. In GH, I counted only 46 occurrences of === RUN in the test output (example). We should check what is the sources of the discrepancy.

All in all, I really like this change and I hope we can merge it soon.

@codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (d74de59) to head (4731ec5).
Report is 40 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15407      +/-   ##
==========================================
- Coverage   49.21%   49.21%   -0.01%     
==========================================
  Files        2574     2577       +3     
  Lines      189052   189083      +31     
==========================================
+ Hits        93050    93059       +9     
- Misses      88667    88687      +20     
- Partials     7335     7337       +2
Flag Coverage Δ
go-unit-tests 49.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz
Copy link
Contributor Author

janisz commented May 22, 2025

@vikin91 The difference in test count comes from "virtual test cases" in prow. To make it easier to debug and highlight issues with prow (as it does not support steps) we create a junit record for steps. So we have 14 additional tests that are reported that are not accutal tests. See the list below:

  1. image-prefetcher-prebuilt-start: Start image pre-fetcher for pre-built images (NOT built for current commit). 0s
  2. image-prefetcher-system-start: Start image pre-fetcher for system images (built for current commit). 0s
  3. Cluster: Create GKE 0s
  4. Cluster: Destroy GKE 0s
  5. Clone the correct source code into an image and tag it as src 8m4s
  6. Find the input image root and tag it into the pipeline 0s
  7. Run multi-stage test gke-sensor-integration-tests - gke-sensor-integration-tests-stackrox-stackrox-begin container test 18s
  8. Run multi-stage test gke-sensor-integration-tests - gke-sensor-integration-tests-stackrox-stackrox-e2e-test container test 37m8s
  9. Run multi-stage test gke-sensor-integration-tests - gke-sensor-integration-tests-stackrox-stackrox-end container test 42s
  10. Run multi-stage test post phase 51s
  11. Run multi-stage test pre phase 6m17s
  12. Run multi-stage test test phase 37m19s
  13. Store build results into a layer on top of src and save as test-bin 14m52s
  14. Job run should complete before timeout

@janisz janisz force-pushed the janisz/run_sensor_integration_test_on_gha branch from 26e7a54 to 1e007a4 Compare May 22, 2025 18:09
@janisz
save coverage
600ae35 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the janisz/run_sensor_integration_test_on_gha branch from 1e007a4 to 600ae35 Compare May 22, 2025 18:52
janisz added 2 commits May 22, 2025 21:10
@janisz
fix
3e11c5f 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
remove cov
4731ec5 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested review from a team and vikin91 May 26, 2025 09:15
@janisz
Copy link
Contributor Author

janisz commented May 27, 2025

@vikin91 PTAL

vikin91
vikin91 approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the initiative and explanation of the details in the comments

@janisz janisz merged commit d3cd4db into master May 28, 2025
88 checks passed
@janisz janisz deleted the janisz/run_sensor_integration_test_on_gha branch May 28, 2025 09:23
@janisz janisz changed the title tests: run sensor integration tests on GHA ROX-29505: run sensor integration tests on GHA May 28, 2025
@janisz janisz mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@vikin91 vikin91 vikin91 approved these changes

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees

No one assigned

Labels

area/ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janisz @rhacs-bot @vikin91 @rhybrillou