ROX-28973: update image tagging and expiration in Konflux#15429
ROX-28973: update image tagging and expiration in Konflux#15429
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 1300dcc. To use with deploy scripts, first |
|
/retest operator-bundle-on-push |
There was a problem hiding this comment.
Hey @tommartensen - I've reviewed your changes - here's some feedback:
- Consider centralizing the Konflux task bundle digest into a shared parameter or constant to avoid manual updates across every pipeline file.
- The repeated determine-image-expiration block in each pipeline could be DRYed by extracting it into a reusable template or include to simplify maintenance.
- Resolve the TODO to update to the real task reference bundle digest before merging.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
/retest retag-scanner |
|
/retest retag-scanner-db |
|
/retest retag-scanner-slim |
|
/retest retag-scanner-db-slim |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15429 +/- ##
=======================================
Coverage 49.23% 49.24%
=======================================
Files 2578 2578
Lines 189280 189280
=======================================
+ Hits 93197 93206 +9
+ Misses 88744 88736 -8
+ Partials 7339 7338 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
@tommartensen: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Per title. This is a manual update, because of the changes to the interface of
determine-image-expiration.TODO:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Passing Konflux pipelines and validation in stackrox/konflux-tasks#58