Skip to content

ROX-29479: switch to custom Konflux quay.io repositories#15441

Merged
msugakov merged 5 commits intomasterfrom
tm/ROX-29479-konflux-custom-repos
May 27, 2025
Merged

ROX-29479: switch to custom Konflux quay.io repositories#15441
msugakov merged 5 commits intomasterfrom
tm/ROX-29479-konflux-custom-repos

Conversation

@tommartensen
Copy link
Contributor

@tommartensen tommartensen commented May 27, 2025 •
edited
Loading

Description

Per title and ticket.
Update the references in operator-bundle as well.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Passing CI suffices.

@tommartensen tommartensen self-assigned this May 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added the konflux-build Run Konflux in PR. Push commit to trigger it. label May 27, 2025
@msugakov msugakov self-requested a review May 27, 2025 11:16
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 27, 2025 •
edited
Loading

Images are ready for the commit at 04fe8af.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-815-g04fe8af801.

@tommartensen tommartensen marked this pull request as ready for review May 27, 2025 12:00
@tommartensen tommartensen requested a review from a team as a code owner May 27, 2025 12:00
sourcery-ai[bot]
sourcery-ai bot reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tommartensen - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

msugakov
msugakov reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's see if it builds cleanly and creates our custom snapshot in the end.

@msugakov
Copy link
Contributor

msugakov commented May 27, 2025

Please don't forget backport-for-konflux* labels. Unfortunately, adding them will trigger Konflux CI again (also: once per each label you add) so it could make sense to wait until the CI finishes here and check the result before you add the labels.

@codecov
Copy link

codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.24%. Comparing base (e222e6e) to head (04fe8af).
Report is 11 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15441      +/-   ##
==========================================
- Coverage   49.24%   49.24%   -0.01%     
==========================================
  Files        2578     2578              
  Lines      189155   189155              
==========================================
- Hits        93149    93145       -4     
- Misses      88674    88678       +4     
  Partials     7332     7332
Flag Coverage Δ
go-unit-tests 49.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@msugakov
Copy link
Contributor

msugakov commented May 27, 2025

/test gke-upgrade-tests

msugakov
msugakov approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All builds completed and our custom snapshot got created with all repos pointing at quay.io/rhacs-eng/release-* images. https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/rh-acs-tenant/applications/acs/snapshots/acs-4-8-0-815-g04fe8af801-fast-20250527t131324z

@msugakov msugakov enabled auto-merge (squash) May 27, 2025 15:59
@msugakov msugakov added backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 labels May 27, 2025
@msugakov msugakov merged commit d2da273 into master May 27, 2025
114 of 118 checks passed
@msugakov msugakov deleted the tm/ROX-29479-konflux-custom-repos branch May 27, 2025 18:49
@msugakov msugakov restored the tm/ROX-29479-konflux-custom-repos branch May 28, 2025 08:00
@msugakov msugakov deleted the tm/ROX-29479-konflux-custom-repos branch May 28, 2025 08:02
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
@tommartensen @ajheflin
ROX-29479: switch to custom Konflux quay.io repositories (#15441)
b9f8dfa 
 Conflicts:
	.tekton/operator-bundle-pipeline.yaml
ajheflin pushed a commit that referenced this pull request Jun 25, 2025
@tommartensen @ajheflin
ROX-29479: switch to custom Konflux quay.io repositories (#15441)
d4773f8 
 Conflicts:
	.tekton/operator-bundle-pipeline.yaml
msugakov pushed a commit that referenced this pull request Jun 27, 2025
@tommartensen @msugakov
ROX-29479: switch to custom Konflux quay.io repositories (#15441)
941e5c4 
 Conflicts:
	.tekton/operator-bundle-pipeline.yaml
ajheflin pushed a commit that referenced this pull request Jun 27, 2025
@tommartensen @ajheflin
ROX-29479: switch to custom Konflux quay.io repositories (#15441)
c6ef383
msugakov pushed a commit that referenced this pull request Jun 27, 2025
@tommartensen @msugakov
ROX-29479: switch to custom Konflux quay.io repositories (#15441)
923cc1c 
 Conflicts:
	.tekton/operator-bundle-pipeline.yaml
msugakov pushed a commit that referenced this pull request Jul 1, 2025
@tommartensen @msugakov
ROX-29479: switch to custom Konflux quay.io repositories (#15441)
b5a8b89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@msugakov msugakov msugakov approved these changes

Assignees

@tommartensen tommartensen

Labels

backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommartensen @rhacs-bot @msugakov