ROX-29478: Revise GHA/Konflux suppression#15442
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at eae3062. To use with deploy scripts, first |
3577cd2 to
2f7236a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15442 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 2581 2581
Lines 189326 189326
=======================================
+ Hits 93254 93255 +1
Misses 88733 88733
+ Partials 7339 7338 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2f7236a to
e88f70c
Compare
There was a problem hiding this comment.
Hey @msugakov - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tommartensen
left a comment
There was a problem hiding this comment.
LGTM, pending task digest update.
I reverted changes from #15309 except for changes in `.tekton/` directory (where the new task was used because that'll be updated in this same PR). My sequence was: ``` git revert 0309e52 git reset --soft HEAD~ git restore --staged .tekton git commit ``` No other changes. This makes sure `should-konflux-replace-gha-build.*` stuff disappears as well as its use in GHA.
e88f70c to
4f25c10
Compare
|
@msugakov: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This change mostly undoes #15309, per the ticket.
Goes together with stackrox/konflux-tasks#59.
User-facing documentation
Testing and quality
Automated testing
Removed tests of the deleted functionality.
How I validated my change
See stackrox/konflux-tasks#59