ROX-29495: Add time window to external ip flows service#15454
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey @bradr5 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 8436d58. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15454 +/- ##
==========================================
- Coverage 49.24% 49.23% -0.01%
==========================================
Files 2578 2578
Lines 189182 189182
==========================================
- Hits 93161 93151 -10
- Misses 88686 88693 +7
- Partials 7335 7338 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedrottimark
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the existing
/v1/networkgraph/cluster/{clusterId}/externalentities/{entityId}/flowscall to include asincequery parameter set to the network graphtimeWindowvariable.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Manually tested instance.
Before:
/v1/networkgraph/cluster/d4368447-c8f3-4e64-9e07-00b8a5ed226c/externalentities/d4368447-c8f3-4e64-9e07-00b8a5ed226c__MTQyLjI1MC4xNTIuODIvMzI/flows?since=2025-05-27T19:46:08.048ZAfter:
/v1/networkgraph/cluster/d4368447-c8f3-4e64-9e07-00b8a5ed226c/externalentities/d4368447-c8f3-4e64-9e07-00b8a5ed226c__MTQyLjI1MC4xNTIuODIvMzI/flows?since=2025-05-27T19:46:08.048Z