ROX-29493: Render component vulnerabilities table if imageMetadata#15455
Merged
pedrottimark merged 1 commit intomasterfrom May 28, 2025
Merged
ROX-29493: Render component vulnerabilities table if imageMetadata#15455pedrottimark merged 1 commit intomasterfrom
pedrottimark merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Hey @pedrottimark - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 9d1a464. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15455 +/- ##
==========================================
- Coverage 49.24% 49.24% -0.01%
==========================================
Files 2578 2578
Lines 189182 189182
==========================================
- Hits 93161 93157 -4
- Misses 88686 88688 +2
- Partials 7335 7337 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dvail
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It might help to ignore whitespace for review.
Problem
Thank you:
Component vulnerabilities tables render
PartialCVEDataAlertelement if eithersummaryorimageMetadataare absent.Analysis
Other tables render
PartialCVEDataAlertifsummaryis absent.This seems like copy-paste-edit from one condition to two conditions.
Solution
summaryconditionally, else nothing.WhateverComponentVulnerabilitiesTableconditionally elsePartialCVEDataAlertelement.That is, in the context, omit secondary
summarysilently if absent, and render Partial CVE data only if primaryimageMetadatais absent.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lintin ui/apps/platform folder.Manual testing with Advisory column
Image: registry.redhat.io/openshift-logging/logging-curator5-rhel9:v5.8.1-478
Visit /main/vulnerabilities/all-images search for image above, and then expand rows for GHSA and PYSEC vulnerabilities.
Before changes, see Partial CVE data
After changes, see absence of
summarybut presence ofImageComponentVulnerabilitiesTableelement.Not sure how likely to find similar situation for deployment.