Skip to content

ROX-29479: Check Konflux image existence in release- repos#15463

Merged
msugakov merged 1 commit intomasterfrom
misha/ROX-29479-update-image-checks
May 28, 2025
Merged

ROX-29479: Check Konflux image existence in release- repos#15463
msugakov merged 1 commit intomasterfrom
misha/ROX-29479-update-image-checks

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented May 28, 2025

Description

Part of the image repos move for Konflux-built images from quay.io/rhacs-eng/<something> to quay.io/rhacs-eng/release-<something>.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

GHA Style CI should be green.

@msugakov msugakov added konflux-build Run Konflux in PR. Push commit to trigger it. backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 labels May 28, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@msugakov msugakov marked this pull request as ready for review May 28, 2025 08:24
@msugakov msugakov requested a review from tommartensen May 28, 2025 08:24
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @msugakov - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at b5f6922.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-826-gb5f6922b37.

@msugakov msugakov enabled auto-merge (squash) May 28, 2025 08:55
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.24%. Comparing base (f56e583) to head (b5f6922).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15463   +/-   ##
=======================================
  Coverage   49.24%   49.24%           
=======================================
  Files        2578     2578           
  Lines      189280   189280           
=======================================
  Hits        93207    93207           
  Misses      88735    88735           
  Partials     7338     7338           
Flag Coverage Δ
go-unit-tests 49.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@msugakov msugakov merged commit de70e47 into master May 28, 2025
116 of 124 checks passed
@msugakov msugakov deleted the misha/ROX-29479-update-image-checks branch May 28, 2025 11:08
msugakov added a commit that referenced this pull request Jul 1, 2025
msugakov added a commit that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants