ROX-29452: Fix confusing certrefresh logs#15464
Conversation
There was a problem hiding this comment.
Hey @vladbologa - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at b3576ca. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15464 +/- ##
==========================================
- Coverage 49.24% 49.23% -0.01%
==========================================
Files 2578 2578
Lines 189280 189280
==========================================
- Hits 93202 93196 -6
- Misses 88739 88744 +5
- Partials 7339 7340 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test ocp-4-18-nongroovy-e2e-tests |
|
@vladbologa: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR fixes some confusing log messages related to certificate refresh, e.g.:
These were replaced with messages like "secured cluster TLS certificates not found", and so on.
Another point in the Jira ticket is that these messages are wrongly displayed when a connection to Central is not available. That was already fixed by #13596
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Trivial change, CI should be enough.