Skip to content

ROX-29411: adding wait-for-image task to retag pipeline#15552

Merged
tommartensen merged 14 commits intomasterfrom
tm/ROX-29411-wait-for-attestation
Jun 12, 2025
Merged

ROX-29411: adding wait-for-image task to retag pipeline#15552
tommartensen merged 14 commits intomasterfrom
tm/ROX-29411-wait-for-attestation

Conversation

@tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Jun 3, 2025 •
edited
Loading

Description

Because this better fails the retag pipeline, if the image is not available. Also bumping the task references to the latest available version.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Konflux builds pass.

@tommartensen tommartensen self-assigned this Jun 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added the konflux-build Run Konflux in PR. Push commit to trigger it. label Jun 3, 2025
@tommartensen tommartensen changed the title adding wait-for-image task to retag pipeline ROX-29411: adding wait-for-image task to retag pipeline Jun 3, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jun 3, 2025 •
edited
Loading

Images are ready for the commit at dcea612.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-56-gdcea6125de.

@codecov
Copy link

codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.65%. Comparing base (aa7c512) to head (dcea612).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15552      +/-   ##
==========================================
- Coverage   48.80%   48.65%   -0.16%     
==========================================
  Files        2590     2590              
  Lines      190492   190492              
==========================================
- Hits        92965    92679     -286     
- Misses      90229    90528     +299     
+ Partials     7298     7285      -13
Flag Coverage Δ
go-unit-tests 48.65% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tommartensen tommartensen mentioned this pull request Jun 4, 2025
Merged
@stackrox stackrox deleted a comment from openshift-ci bot Jun 11, 2025
@tommartensen tommartensen added backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 backport-for-4.8-konflux-release labels Jun 11, 2025
@tommartensen

This comment was marked as off-topic.

Sign in to view
@tommartensen

This comment was marked as off-topic.

Sign in to view
@tommartensen tommartensen marked this pull request as ready for review June 11, 2025 13:35
@tommartensen tommartensen requested a review from a team as a code owner June 11, 2025 13:35
@stackrox stackrox deleted a comment from openshift-ci bot Jun 11, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jun 11, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jun 11, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jun 11, 2025
@tommartensen tommartensen enabled auto-merge (squash) June 11, 2025 13:45
msugakov
msugakov reviewed Jun 11, 2025
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025 •
edited
Loading

@tommartensen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests d046b0c link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tommartensen tommartensen requested a review from msugakov June 12, 2025 07:40
@stackrox stackrox deleted a comment from openshift-ci bot Jun 12, 2025
msugakov
msugakov reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a comment tweak.

@tommartensen @msugakov
Update .tekton/retag-pipeline.yaml
dcea612 
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
msugakov
msugakov approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw operator-bundle build succeeding in https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/rh-acs-tenant/applications/acs/pipelineruns/operator-bundle-on-push-rb7bt, therefore approving.

@tommartensen tommartensen merged commit a2a1a18 into master Jun 12, 2025
95 of 116 checks passed
@tommartensen tommartensen deleted the tm/ROX-29411-wait-for-attestation branch June 12, 2025 11:16
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
@tommartensen @ajheflin
ROX-29411: adding wait-for-image task to retag pipeline (#15552)
7048b4b
ajheflin pushed a commit that referenced this pull request Jun 25, 2025
@tommartensen @ajheflin
ROX-29411: adding wait-for-image task to retag pipeline (#15552)
bf83559
ajheflin pushed a commit that referenced this pull request Jun 27, 2025
@tommartensen @ajheflin
ROX-29411: adding wait-for-image task to retag pipeline (#15552)
6dad023
ajheflin pushed a commit that referenced this pull request Jun 27, 2025
@tommartensen @ajheflin
ROX-29411: adding wait-for-image task to retag pipeline (#15552)
abc065b
msugakov pushed a commit that referenced this pull request Jun 30, 2025
@tommartensen @msugakov
ROX-29411: adding wait-for-image task to retag pipeline (#15552)
1ae0cd7
msugakov pushed a commit that referenced this pull request Jul 1, 2025
@tommartensen @msugakov
ROX-29411: adding wait-for-image task to retag pipeline (#15552)
272cec4
msugakov pushed a commit that referenced this pull request Jul 2, 2025
@tommartensen @msugakov
ROX-29411: adding wait-for-image task to retag pipeline (#15552)
3c19e04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msugakov msugakov msugakov approved these changes

Assignees

@tommartensen tommartensen

Labels

backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 backport-for-4.8-konflux-release konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommartensen @rhacs-bot @msugakov