Skip to content

ROX-28233: Add fips-operator-bundle-check-oci-ta#15583

Merged
kurlov merged 7 commits intomasterfrom
akurlov/ROX-28233-add-fips-operator-bundle-check-oci-ta
Jun 24, 2025
Merged

ROX-28233: Add fips-operator-bundle-check-oci-ta#15583
kurlov merged 7 commits intomasterfrom
akurlov/ROX-28233-add-fips-operator-bundle-check-oci-ta

Conversation

@kurlov
Copy link
Member

@kurlov kurlov commented Jun 5, 2025 •
edited
Loading

Description

Add fips-operator-bundle-check-oci-ta task to operator-bundle pipeline

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

How I validated my change

Checked the logs of the operator-bundle task

@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added the konflux-build Run Konflux in PR. Push commit to trigger it. label Jun 5, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jun 5, 2025 •
edited
Loading

Images are ready for the commit at 063482f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-78-g063482f712.

@codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.81%. Comparing base (1aaac87) to head (063482f).
Report is 18 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15583   +/-   ##
=======================================
  Coverage   48.80%   48.81%           
=======================================
  Files        2590     2590           
  Lines      190518   190591   +73     
=======================================
+ Hits        92979    93029   +50     
- Misses      90237    90252   +15     
- Partials     7302     7310    +8
Flag Coverage Δ
go-unit-tests 48.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

msugakov
msugakov reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but for some reason I don't see operator-bundle Konflux job in the list.

Could you please try kicking-off CI again? If you'll be doing that, I'd suggest two things: please rebase from recent master and bump the digest of the task (the current one I see is quay.io/konflux-ci/tekton-catalog/task-fips-operator-bundle-check-oci-ta:0.1@sha256:1eea7564e15a5003396de9ac10e24ae53ebf1c980d1541cbde0b6cbadd043d5d).

@msugakov msugakov added backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 backport-for-4.8-konflux-release labels Jun 11, 2025
msugakov
msugakov reviewed Jun 11, 2025
View reviewed changes
@kurlov kurlov marked this pull request as ready for review June 17, 2025 13:29
@kurlov kurlov requested a review from a team as a code owner June 17, 2025 13:29
sourcery-ai[bot]
sourcery-ai bot reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kurlov - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kurlov
Copy link
Member Author

kurlov commented Jun 17, 2025

/test scanner-v4-on-push

@kurlov
Copy link
Member Author

kurlov commented Jun 17, 2025

/test scanner-v4-db-on-push

@kurlov
Copy link
Member Author

kurlov commented Jun 17, 2025

/test central-db-on-push

@kurlov
Copy link
Member Author

kurlov commented Jun 17, 2025

/test roxctl-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jun 17, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jun 17, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jun 17, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jun 17, 2025
@kurlov
Copy link
Member Author

kurlov commented Jun 17, 2025

/retest

tommartensen
tommartensen requested changes Jun 18, 2025
View reviewed changes
@kurlov @tommartensen
Apply suggestions from code review
bac1daa 
Co-authored-by: Tom Martensen <tmartens@redhat.com>
@msugakov
Copy link
Contributor

msugakov commented Jun 18, 2025

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jun 18, 2025
msugakov
msugakov reviewed Jun 18, 2025
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2025

@kurlov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests 063482f link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kurlov
Copy link
Member Author

kurlov commented Jun 20, 2025

/test roxctl-on-push

@kurlov
Copy link
Member Author

kurlov commented Jun 20, 2025

/test operator-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jun 20, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jun 20, 2025
@kurlov
Copy link
Member Author

kurlov commented Jun 20, 2025

/test operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jun 20, 2025
@kurlov kurlov requested review from msugakov and tommartensen June 20, 2025 12:39
@msugakov
Copy link
Contributor

msugakov commented Jun 23, 2025

/test operator-bundle-on-push

@red-hat-konflux
Copy link
Contributor

red-hat-konflux bot commented Jun 23, 2025

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
quay-proxy no kind "ImageDigestMirrorSet" is registered for version "config.openshift.io/v1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

@stackrox stackrox deleted a comment from openshift-ci bot Jun 23, 2025
msugakov
msugakov approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Does not make sense as the answer to the stated question.
OTOH, I looked in the logs enough times so I'm ok to approve.

@kurlov kurlov merged commit 2cd250c into master Jun 24, 2025
100 of 109 checks passed
@kurlov kurlov deleted the akurlov/ROX-28233-add-fips-operator-bundle-check-oci-ta branch June 24, 2025 12:50
msugakov pushed a commit that referenced this pull request Jun 25, 2025
@kurlov @tommartensen @msugakov
ROX-28233: Add fips-operator-bundle-check-oci-ta (#15583)
cd5bddb 
Co-authored-by: Tom Martensen <tmartens@redhat.com>
msugakov pushed a commit that referenced this pull request Jun 30, 2025
@kurlov @tommartensen @msugakov
ROX-28233: Add fips-operator-bundle-check-oci-ta (#15583)
447f02e 
Co-authored-by: Tom Martensen <tmartens@redhat.com>
msugakov pushed a commit that referenced this pull request Jul 1, 2025
@kurlov @tommartensen @msugakov
ROX-28233: Add fips-operator-bundle-check-oci-ta (#15583)
71fec44 
Co-authored-by: Tom Martensen <tmartens@redhat.com>
msugakov pushed a commit that referenced this pull request Jul 2, 2025
@kurlov @tommartensen @msugakov
ROX-28233: Add fips-operator-bundle-check-oci-ta (#15583)
c501a77 
Co-authored-by: Tom Martensen <tmartens@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@msugakov msugakov msugakov approved these changes

@tommartensen tommartensen tommartensen approved these changes

Assignees

No one assigned

Labels

backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 backport-for-4.8-konflux-release konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kurlov @rhacs-bot @msugakov @tommartensen