Skip to content

ROX-29755: Recover reprocessing when Sensor's are 'stuck' (#15802)#15930

Merged
lvalerom merged 1 commit intorelease-4.8from
backport-15802-to-release-4.8
Jul 9, 2025
Merged

ROX-29755: Recover reprocessing when Sensor's are 'stuck' (#15802)#15930
lvalerom merged 1 commit intorelease-4.8from
backport-15802-to-release-4.8

Conversation

@lvalerom
Copy link
Copy Markdown
Contributor

@lvalerom lvalerom commented Jul 8, 2025 •
edited
Loading

(cherry picked from commit 933c558)

Description

Backport 15802 to release 4.8

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added area/central backport PR to backport changes from master to release branch labels Jul 8, 2025
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Jul 8, 2025

Images are ready for the commit at c82d13a.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.0-1-gc82d13a35c.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.55556% with 14 lines in your changes missing coverage. Please review.

Project coverage is 48.81%. Comparing base (0f0cf4d) to head (c82d13a).

Files with missing lines Patch % Lines
central/reprocessor/reprocessor.go 85.18% 7 Missing and 1 partial ⚠️
...ntral/sensor/service/connection/connection_impl.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-4.8   #15930      +/-   ##
===============================================
- Coverage        48.81%   48.81%   -0.01%     
===============================================
  Files             2590     2592       +2     
  Lines           190478   190674     +196     
===============================================
+ Hits             92991    93080      +89     
- Misses           90186    90287     +101     
- Partials          7301     7307       +6
Flag Coverage Δ
go-unit-tests 48.81% <80.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lvalerom lvalerom marked this pull request as ready for review July 8, 2025 12:42
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 8, 2025

@lvalerom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-sensor-integration-tests c82d13a link false /test gke-sensor-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lvalerom lvalerom added this to the 4.8.1-rc.1 milestone Jul 8, 2025
@lvalerom lvalerom requested review from dcaravel and janisz July 9, 2025 08:55
@lvalerom lvalerom merged commit cc5ce35 into release-4.8 Jul 9, 2025
109 of 118 checks passed
@lvalerom lvalerom deleted the backport-15802-to-release-4.8 branch July 9, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@dcaravel dcaravel Awaiting requested review from dcaravel

Assignees

No one assigned

Labels

area/central backport PR to backport changes from master to release branch

Projects

None yet

Milestone

4.8.1-rc.1

Development

Successfully merging this pull request may close these issues.

4 participants

@lvalerom @rhacs-bot @janisz @dcaravel