Skip to content

ROX-29994: Remove 3 roxctl options that have been deprecated#16066

Merged
clickboo merged 1 commit intomasterfrom
boo-remove-deprecated-roxctl-options
Jul 18, 2025
Merged

ROX-29994: Remove 3 roxctl options that have been deprecated#16066
clickboo merged 1 commit intomasterfrom
boo-remove-deprecated-roxctl-options

Conversation

@clickboo
Copy link
Contributor

@clickboo clickboo commented Jul 17, 2025

Description

Remove the following 3 roxctl options that have been deprecated since 4.7 or prior:
--create-admission-controller
--admission-controller-enabled
--slim-collector

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI only

@clickboo clickboo requested a review from a team as a code owner July 17, 2025 13:59
@red-hat-konflux
Copy link
Contributor

red-hat-konflux bot commented Jul 17, 2025

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
quay-proxy no kind "ImageDigestMirrorSet" is registered for version "config.openshift.io/v1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jul 17, 2025 •
edited
Loading

Images are ready for the commit at 7293045.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-255-g7293045409.

@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.68%. Comparing base (3d19a91) to head (7293045).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16066      +/-   ##
==========================================
- Coverage   48.68%   48.68%   -0.01%     
==========================================
  Files        2603     2604       +1     
  Lines      191590   191656      +66     
==========================================
+ Hits        93283    93300      +17     
- Misses      90977    91023      +46     
- Partials     7330     7333       +3
Flag Coverage Δ
go-unit-tests 48.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clickboo clickboo force-pushed the boo-remove-deprecated-roxctl-options branch 2 times, most recently from 626abda to 180ed8e Compare July 17, 2025 17:17
@clickboo clickboo requested a review from a team as a code owner July 18, 2025 07:58
@janisz
Copy link
Contributor

janisz commented Jul 18, 2025

@janisz janisz requested review from Molter73 and Stringy July 18, 2025 08:56
janisz
janisz approved these changes Jul 18, 2025
View reviewed changes
@clickboo clickboo force-pushed the boo-remove-deprecated-roxctl-options branch from cdd45f2 to bfa2025 Compare July 18, 2025 09:10
Stringy
Stringy reviewed Jul 18, 2025
View reviewed changes
@clickboo clickboo requested a review from Stringy July 18, 2025 09:43
Stringy
Stringy approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Collector perspective

@clickboo clickboo enabled auto-merge (squash) July 18, 2025 09:53
@clickboo
Copy link
Contributor Author

clickboo commented Jul 18, 2025

/test gke-nongroovy-e2e-tests

@clickboo clickboo force-pushed the boo-remove-deprecated-roxctl-options branch from 90b2cbe to 7293045 Compare July 18, 2025 10:58
@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2025 •
edited
Loading

@clickboo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-19-nongroovy-e2e-tests a4df96b link false /test ocp-4-19-nongroovy-e2e-tests
ci/prow/gke-qa-e2e-tests 7293045 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@clickboo
Copy link
Contributor Author

clickboo commented Jul 18, 2025

/test gke-upgrade-tests

@clickboo clickboo merged commit 0179b9c into master Jul 18, 2025
88 of 89 checks passed
@clickboo clickboo deleted the boo-remove-deprecated-roxctl-options branch July 18, 2025 16:46
Stringy pushed a commit that referenced this pull request Aug 15, 2025
@clickboo @Stringy
ROX-29994: Remove 3 roxctl options that have been deprecated (#16066)
0910154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@Stringy Stringy Stringy approved these changes

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

No one assigned

Labels

area/roxctl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clickboo @rhacs-bot @janisz @Stringy