Skip to content

ROX-30343: Update Node.js requirement for ui folder to 20.0.0#16186

Merged
pedrottimark merged 1 commit intomasterfrom
ROX-30343-package.json-engines-node-20
Jul 29, 2025
Merged

ROX-30343: Update Node.js requirement for ui folder to 20.0.0#16186
pedrottimark merged 1 commit intomasterfrom
ROX-30343-package.json-engines-node-20

Conversation

@pedrottimark
Copy link
Copy Markdown
Contributor

@pedrottimark pedrottimark commented Jul 28, 2025

Description

Problems

  1. Inconsistent requirement:
    • ui/package.json file has "node": ">=18.0.0"
    • ui/apps/platform/package.json file has: "node": "^18.18.0 || >=20.0.0"
  2. Possibly fragile condition to mix ^ with >=

Analysis

Node.js 18 has End of Life status
https://nodejs.org/en/about/previous-releases

Solution

Thank you, David Vail for suggestion that we update to 20.0.0

User-facing documentation

  • CHANGELOG.md is updated
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@pedrottimark pedrottimark requested a review from a team as a code owner July 28, 2025 19:57
@pedrottimark pedrottimark requested review from dvail and janisz and removed request for a team July 28, 2025 19:58
@rhacs-bot
Copy link
Copy Markdown
Contributor

Images are ready for the commit at fcdbed3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-329-gfcdbed333e.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.69%. Comparing base (938780b) to head (fcdbed3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16186   +/-   ##
=======================================
  Coverage   48.69%   48.69%           
=======================================
  Files        2606     2606           
  Lines      191786   191786           
=======================================
+ Hits        93388    93389    +1     
+ Misses      91065    91064    -1     
  Partials     7333     7333           
Flag Coverage Δ
go-unit-tests 48.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pedrottimark pedrottimark merged commit 2e6c319 into master Jul 29, 2025
103 of 104 checks passed
@pedrottimark pedrottimark deleted the ROX-30343-package.json-engines-node-20 branch July 29, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants