Skip to content

(do not merge): Test branch for plugin CR#16293

Closed
dvail wants to merge 10 commits intomasterfrom
dv/exp/test-plugin-cr-build
Closed

(do not merge): Test branch for plugin CR#16293
dvail wants to merge 10 commits intomasterfrom
dv/exp/test-plugin-cr-build

Conversation

@dvail
Copy link
Copy Markdown
Contributor

@dvail dvail commented Aug 4, 2025

feat(m2m): exchange opaque k8s tokens

Apply suggestion from @parametalol

fix(m2m): use in-cluster k8s config

fix(m2m): allow []any claim value if any is string

fix(m2m): try to extract generic claims

Test branch for deploying plugin via CR

Merge remote-tracking branch 'origin/michael/k8s-opaque-token' into dv/exp/test-plugin-cr-build

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@dvail
Copy link
Copy Markdown
Contributor Author

dvail commented Aug 4, 2025

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Aug 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail force-pushed the dv/ROX-30334-add-permission-context-for-plugin branch from 72e5b89 to 0c689a0 Compare August 4, 2025 14:59
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Aug 4, 2025

Images are ready for the commit at 102fa69.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-405-g102fa69159.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 7.81250% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.90%. Comparing base (b12f15f) to head (102fa69).
⚠️ Report is 557 commits behind head on master.

Files with missing lines Patch % Lines
central/auth/m2m/kube_token_review.go 0.00% 27 Missing ⚠️
central/auth/m2m/verifier.go 0.00% 22 Missing ⚠️
central/auth/m2m/claims.go 0.00% 6 Missing ⚠️
central/auth/m2m/id_token.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16293      +/-   ##
==========================================
- Coverage   48.91%   48.90%   -0.01%     
==========================================
  Files        2613     2614       +1     
  Lines      193188   193245      +57     
==========================================
+ Hits        94496    94510      +14     
- Misses      91268    91312      +44     
+ Partials     7424     7423       -1     
Flag Coverage Δ
go-unit-tests 48.90% <7.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail force-pushed the dv/exp/test-plugin-cr-build branch from cc82724 to 102fa69 Compare August 4, 2025 15:49
Base automatically changed from dv/ROX-30334-add-permission-context-for-plugin to master August 4, 2025 19:38
@dvail dvail closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants