ROX-29060: minor follow-up refactors#16327
Merged
rhybrillou merged 1 commit intomasterfrom Aug 6, 2025
Merged
Conversation
vikin91
approved these changes
Aug 6, 2025
Contributor
vikin91
left a comment
There was a problem hiding this comment.
Makes perfect sense! Thanks for gathering those issues in a PR!
Contributor
|
Images are ready for the commit at 78b266b. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16327 +/- ##
==========================================
- Coverage 49.07% 49.07% -0.01%
==========================================
Files 2628 2628
Lines 194118 194118
==========================================
- Hits 95270 95268 -2
Misses 91392 91392
- Partials 7456 7458 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Stringy
pushed a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-ups to #15076
User-facing documentation
is updated ORupdate is not neededis created and is linked above ORis not neededTesting and quality
Automated testing
How I validated my change
CI