ROX-30454: GraphQL Updates for ImageV2 by ajheflin · Pull Request #16414 · stackrox/stackrox

ajheflin · 2025-08-14T19:42:28Z

Description

This PR adds the GraphQL resolvers for Image V2s, as well as adds logic to make other resolvers that are dependent on images to be able to use either the Image V1 Resolvers, or the Image V2 Resolvers, dependent on whether or not the new image data model is enabled.

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

How I validated my change

CI

openshift-ci · 2025-08-14T19:42:32Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

red-hat-konflux · 2025-08-14T19:42:34Z

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
central-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
main-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
operator-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
operator-bundle-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-collector	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
roxctl-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`

rhacs-bot · 2025-08-15T15:40:11Z

Images are ready for the commit at 0fc779b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-514-g0fc779b392.

codecov · 2025-08-18T20:48:11Z

Codecov Report

❌ Patch coverage is 13.44668% with 560 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.06%. Comparing base (2aebffc) to head (0fc779b).
⚠️ Report is 76 commits behind head on master.

Files with missing lines	Patch %	Lines
central/graphql/resolvers/images_v2.go	14.34%	203 Missing ⚠️
central/graphql/resolvers/generated.go	14.50%	171 Missing ⚠️
central/graphql/resolvers/images.go	10.12%	68 Missing and 3 partials ⚠️
central/graphql/resolvers/components_v1.go	0.00%	53 Missing ⚠️
central/graphql/resolvers/vulnerabilities_v1.go	0.00%	20 Missing ⚠️
...entral/graphql/resolvers/vulnerability_requests.go	0.00%	14 Missing ⚠️
central/graphql/resolvers/resolver.go	0.00%	7 Missing ⚠️
central/graphql/resolvers/search.go	57.14%	2 Missing and 4 partials ⚠️
...lityrequest/manager/querymgr/query_manager_impl.go	0.00%	6 Missing ⚠️
central/graphql/resolvers/deployments.go	55.55%	3 Missing and 1 partial ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #16414      +/-   ##
==========================================
- Coverage   49.07%   49.06%   -0.02%     
==========================================
  Files        2640     2645       +5     
  Lines      195598   196449     +851     
==========================================
+ Hits        95989    96378     +389     
- Misses      92102    92519     +417     
- Partials     7507     7552      +45

Flag	Coverage Δ
go-unit-tests	`49.06% <13.44%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ajheflin · 2025-08-19T13:43:35Z

/retest

central/graphql/resolvers/deployments.go

clickboo

left few comments

central/graphql/resolvers/resolver.go

central/graphql/resolvers/vulnerabilities_v1.go

central/graphql/resolvers/vulnerability_requests.go

central/graphql/resolvers/deployments.go

central/graphql/resolvers/components_v1.go

central/graphql/resolvers/vulnerabilities_v1.go

central/vulnmgmt/vulnerabilityrequest/manager/querymgr/query_manager_impl_test.go

clickboo

left some comments, but lgtm. Would also like @charmik-redhat to review given more subject matter expertise in this area.

central/graphql/resolvers/resolver.go

central/graphql/resolvers/components_v1.go

central/graphql/resolvers/images.go

central/graphql/resolvers/search.go

generated/internalapi/virtualmachine/v1/virtual_machine.pb.go

ajheflin · 2025-08-21T20:04:27Z

/retest

GraphQL

e1da270

ajheflin requested review from charmik-redhat, clickboo, dashrews78 and ksurabhi91 August 14, 2025 19:42

openshift-ci bot added the do-not-merge/work-in-progress label Aug 14, 2025

github-actions bot added the area/central label Aug 14, 2025

ajheflin added 2 commits August 15, 2025 11:09

Code cleanup

d677f30

Quick fix

3a43e49

ajheflin added the ai-assisted label Aug 15, 2025

Add shared generated functions

e02d43f

ajheflin force-pushed the ajheflin/image-v2-graphql branch from 4d86aa4 to e02d43f Compare August 15, 2025 15:48

ajheflin added 12 commits August 15, 2025 12:06

Test fix

8f142ac

More test fixes

18142b2

Update proto.lock

c11ca2a

Add dummy names function for imageV2Resolver

d6c6e82

Add component count

90fdc93

Add other missing functions

a124e29

Add more missing functions

a8e1691

Add missing function

d857d7c

Add last missing functions according to Cursor

97f1a9b

Fix method name

9c32e94

Fix panic in searcher test

19f749e

Fix other nil panic

31264b2

ajheflin marked this pull request as ready for review August 19, 2025 13:43

ajheflin requested a review from a team as a code owner August 19, 2025 13:43

openshift-ci bot removed the do-not-merge/work-in-progress label Aug 19, 2025

clickboo reviewed Aug 19, 2025

View reviewed changes

central/graphql/resolvers/deployments.go Outdated Show resolved Hide resolved

clickboo reviewed Aug 19, 2025

View reviewed changes

central/graphql/resolvers/resolver.go Show resolved Hide resolved

central/graphql/resolvers/vulnerabilities_v1.go Outdated Show resolved Hide resolved

central/graphql/resolvers/vulnerability_requests.go Show resolved Hide resolved

Comments

525d48d

clickboo reviewed Aug 19, 2025

View reviewed changes

central/graphql/resolvers/deployments.go Show resolved Hide resolved

clickboo reviewed Aug 19, 2025

View reviewed changes

central/graphql/resolvers/components_v1.go Outdated Show resolved Hide resolved

Comments 2

7d4770c

clickboo reviewed Aug 20, 2025

View reviewed changes

central/graphql/resolvers/components_v1.go Show resolved Hide resolved

clickboo reviewed Aug 20, 2025

View reviewed changes

central/graphql/resolvers/vulnerabilities_v1.go Show resolved Hide resolved

clickboo reviewed Aug 20, 2025

View reviewed changes

central/vulnmgmt/vulnerabilityrequest/manager/querymgr/query_manager_impl_test.go Show resolved Hide resolved

clickboo approved these changes Aug 20, 2025

View reviewed changes

dashrews78 reviewed Aug 20, 2025

View reviewed changes

central/graphql/resolvers/resolver.go Show resolved Hide resolved

charmik-redhat reviewed Aug 20, 2025

View reviewed changes

Comments

0fc779b

ajheflin requested review from charmik-redhat and dashrews78 August 21, 2025 14:47

charmik-redhat approved these changes Aug 21, 2025

View reviewed changes

ajheflin merged commit 5eb0398 into master Aug 25, 2025
97 of 98 checks passed

ajheflin deleted the ajheflin/image-v2-graphql branch August 25, 2025 14:48

ajheflin mentioned this pull request Aug 27, 2025

ROX-30454: Pass #2 at GraphQL for ImageV2 #16556

Merged

9 tasks

Conversation

ajheflin commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

openshift-ci bot commented Aug 14, 2025

Uh oh!

red-hat-konflux bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhacs-bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ajheflin commented Aug 19, 2025

Uh oh!

Uh oh!

clickboo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clickboo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ajheflin commented Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ajheflin commented Aug 14, 2025 •

edited

Loading

red-hat-konflux bot commented Aug 14, 2025 •

edited

Loading

rhacs-bot commented Aug 15, 2025 •

edited

Loading

codecov bot commented Aug 18, 2025 •

edited

Loading