ROX-29840: access ocp console by davdhacs · Pull Request #16436 · stackrox/stackrox

davdhacs · 2025-08-18T14:24:52Z

The smoke test passes on OCP4.19 with these changes (https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/stackrox_stackrox/16415/pull-ci-stackrox-stackrox-master-ocp-4-19-ui-e2e-tests/1957866898653712384/artifacts/ui-e2e-tests/stackrox-stackrox-e2e-test/build-log.txt):

2025-08-19T19:36:15.932Z running test suite: smoke.test.ts

  Basic connectivity to the OCP plugin
    ✓ should open the OCP web console (16435ms)


  1 passing (16s)

The smoke test fails on ocp4.18 because of some text/intro changes (https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stackrox_stackrox/16415/pull-ci-stackrox-stackrox-master-ocp-4-18-ui-e2e-tests/1957866898611769344):

2025-08-19T19:49:08.425Z running test suite: smoke.test.ts
  Basic connectivity to the OCP plugin
    1) should open the OCP web console
  0 passing (38s)
  1 failing
  1) Basic connectivity to the OCP plugin
       should open the OCP web console:
     AssertionError - 2025-08-19T19:49:46.437Z: Timed out retrying after 10000ms: Expected to find content: 'Skip tour' but never did.
This error occurred while creating the session. Because the session setup failed, we failed the test.
  AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Skip tour' but never did.

Testing of this branch on PR: #16415
This uses the automation-flavors fix to prepare the dotenv file for use is here: https://github.com/stackrox/automation-flavors/pull/324

openshift-ci · 2025-08-18T14:24:57Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

red-hat-konflux · 2025-08-18T14:25:00Z

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
central-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
main-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
operator-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
operator-bundle-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
retag-collector	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
retag-scanner-db-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
retag-scanner-db	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
retag-scanner-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
retag-scanner	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
roxctl-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
scanner-v4-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`
scanner-v4-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: labels`

rhacs-bot · 2025-08-18T14:55:22Z

Images are ready for the commit at bc117fb.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-427-gbc117fbf6f.

codecov · 2025-08-18T15:02:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.91%. Comparing base (92d096f) to head (e6cf762).

Additional details and impacted files

@@                                  Coverage Diff                                  @@
##           dv/ROX-29840-base-config-for-cypress-e2e-test-ocp   #16436      +/-   ##
=====================================================================================
- Coverage                                              49.04%   48.91%   -0.14%     
=====================================================================================
  Files                                                   2625     2616       -9     
  Lines                                                 193919   193258     -661     
=====================================================================================
- Hits                                                   95114    94537     -577     
+ Misses                                                 91351    91290      -61     
+ Partials                                                7454     7431      -23

Flag	Coverage Δ
go-unit-tests	`48.91% <ø> (-0.14%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dvail

Thanks for adding this!

Overall LGTM, although I think a lot of what I added in my parent branch was testing code that we may not want to merge.

I can approve once this branch is targeting master and the UI team can give input regarding the blockHosts option.

dvail · 2025-08-19T20:49:22Z

ui/apps/platform/cypress.config.js

+    // TODO: can we allow the ocp console but block other internet access? do we need to?
+    // blockHosts: ['*.*'], // Browser options


I did find this https://issues.redhat.com/browse/ROX-1865 and this https://github.com/stackrox/rox/pull/2304 from when this option was first added.

My initial thought is that it is probably fine to remove this? It only blocks external requests in CI, so I don't see why it would be a problem if the UI doesn't rely on external requests.

@alwayshooin do you have any context on this somewhat ancient change or opinions on whether or not we can remove this?

ui/apps/platform/cypress.config.js

dvail · 2025-08-19T20:58:01Z

ui/apps/platform/scripts/cypress-ocp.sh

@@ -28,8 +29,8 @@ fi
 artifacts_dir="${TEST_RESULTS_OUTPUT_DIR:-cypress/test-results}/ocp-artifacts"


This change from my branch isn't quite right either - it looks like the video artifacts are not available in the job results. This is something I can fix separately though. I was just looking for video evidence of the test working beyond the text output.

I ran it locally with cypress (and it confirmed it was logging in) but I didn't know how/where to find the video artifacts on a prow run.

Co-authored-by: David Vail <dcvail17@gmail.com>

davdhacs · 2025-08-19T21:15:16Z

I can approve once this branch is targeting master and the UI team can give input regarding the blockHosts option.

Can we merge this into your branch and then you can adjust it from there?

davdhacs · 2025-08-19T21:16:36Z

I can approve once this branch is targeting master and the UI team can give input regarding the blockHosts option.

Can we merge this into your branch and then you can adjust it from there?

If you'd rather do it in one PR with this new branch, I had tested it on a draft PR to master that you can add/change and use: #16415

dvail

Can we merge this into your branch and then you can adjust it from there?

Sounds good to me, thank you!

Co-authored-by: David Vail <dcvail17@gmail.com>

davdhacs added 2 commits August 18, 2025 08:11

add ocp openshift_console_* vars

4a4bc69

add integration-ocp path and allow internet access

18cfdfa

openshift-ci bot added the do-not-merge/work-in-progress label Aug 18, 2025

github-actions bot added the area/ui label Aug 18, 2025

style

bd018bc

setup_e2e_cluster for ocpjobs

95f4234

github-actions bot added the area/ci label Aug 18, 2025

davdhacs added 12 commits August 18, 2025 12:14

use ocpauth fn

5995b38

do not print env

76217b8

list all files

b7254a3

set base url to console

0e539c6

ci_export vars

7b6ccdc

remove old var

6302738

log vars

d62ca61

cypress prefix on vars

693a4bf

single export

d4e9291

try again, keep stderr

7491365

restore hiding stderr

e6cf762

style

71dcf7d

davdhacs requested a review from dvail August 19, 2025 20:20

davdhacs marked this pull request as ready for review August 19, 2025 20:21

davdhacs requested a review from a team as a code owner August 19, 2025 20:21

openshift-ci bot removed the do-not-merge/work-in-progress label Aug 19, 2025

dvail reviewed Aug 19, 2025

View reviewed changes

Remove change to ui/apps/platform/cypress.config.js

bc117fb

Co-authored-by: David Vail <dcvail17@gmail.com>

dvail approved these changes Aug 20, 2025

View reviewed changes

dvail merged commit f612602 into dv/ROX-29840-base-config-for-cypress-e2e-test-ocp Aug 20, 2025
104 of 132 checks passed

dvail added a commit that referenced this pull request Aug 20, 2025

ROX-29840: access ocp console (#16436)

6c0ae80

Co-authored-by: David Vail <dcvail17@gmail.com>

davdhacs deleted the rox-29840-access-ocp-console branch August 20, 2025 13:49

dvail added a commit that referenced this pull request Aug 20, 2025

ROX-29840: access ocp console (#16436)

20b9722

Co-authored-by: David Vail <dcvail17@gmail.com>

dvail added a commit that referenced this pull request Aug 26, 2025

ROX-29840: access ocp console (#16436)

3a19607

Co-authored-by: David Vail <dcvail17@gmail.com>

dvail added a commit that referenced this pull request Aug 28, 2025

ROX-29840: access ocp console (#16436)

d8d3383

Co-authored-by: David Vail <dcvail17@gmail.com>

dvail added a commit that referenced this pull request Aug 29, 2025

ROX-29840: access ocp console (#16436)

bf69407

Co-authored-by: David Vail <dcvail17@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROX-29840: access ocp console#16436

ROX-29840: access ocp console#16436
dvail merged 17 commits intodv/ROX-29840-base-config-for-cypress-e2e-test-ocpfrom
rox-29840-access-ocp-console

davdhacs commented Aug 18, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Aug 18, 2025

Uh oh!

red-hat-konflux bot commented Aug 18, 2025

Uh oh!

rhacs-bot commented Aug 18, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 18, 2025 •

edited

Loading

Uh oh!

dvail left a comment

Uh oh!

dvail Aug 19, 2025

Uh oh!

Uh oh!

dvail Aug 19, 2025

Uh oh!

davdhacs Aug 19, 2025

Uh oh!

davdhacs commented Aug 19, 2025

Uh oh!

davdhacs commented Aug 19, 2025

Uh oh!

dvail left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// TODO: can we allow the ocp console but block other internet access? do we need to?
		// blockHosts: ['.'], // Browser options

		@@ -28,8 +29,8 @@ fi
		artifacts_dir="${TEST_RESULTS_OUTPUT_DIR:-cypress/test-results}/ocp-artifacts"

Conversation

davdhacs commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 18, 2025

Uh oh!

red-hat-konflux bot commented Aug 18, 2025

Uh oh!

rhacs-bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dvail left a comment

Choose a reason for hiding this comment

Uh oh!

dvail Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dvail Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

davdhacs Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

davdhacs commented Aug 19, 2025

Uh oh!

davdhacs commented Aug 19, 2025

Uh oh!

dvail left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

davdhacs commented Aug 18, 2025 •

edited

Loading

rhacs-bot commented Aug 18, 2025 •

edited

Loading

codecov bot commented Aug 18, 2025 •

edited

Loading