ROX-30733: Omit include in optional columns and add CISA KEV comments#16633
ROX-30733: Omit include in optional columns and add CISA KEV comments#16633pedrottimark merged 2 commits intomasterfrom
Conversation
|
Images are ready for the commit at d7b4769. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16633 +/- ##
==========================================
- Coverage 48.72% 48.64% -0.08%
==========================================
Files 2658 2662 +4
Lines 198307 199093 +786
==========================================
+ Hits 96625 96851 +226
- Misses 94112 94654 +542
- Partials 7570 7588 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...platform/src/Containers/Vulnerabilities/VulnerablityReporting/forms/ReportParametersForm.tsx
Outdated
Show resolved
Hide resolved
|
@pedrottimark: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Prerequisite for Ross to add optional column for CISA KEV.
The less the delta to add an optional column, the better.
I had already omitted Include from
ReportParameterDetailsin ROX-29513: Replace CSV report preview with Non-optional columns #15467// Ross CISA KEVcomments because several files need consistent changes.Residue
https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_security_for_kubernetes/4.8/html/operating/managing-vulnerabilities#vulnerability-management20-creating-report_vulnerability-reporting
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with staging demo as central.Manual testing
Visit /main/vulnerabilities/reports/configuration?action=create
Before changes, see presence of Include
After changes, see absence of Include
Also Advisory Name and Advisory Link for consistency with column headings in CSV file