Skip to content

ROX-30702: Adds implementation for plugin CVE detail page#16729

Merged
dvail merged 1 commit intomasterfrom
dv/ROX-30702-implement-cve-detail-page
Sep 10, 2025
Merged

ROX-30702: Adds implementation for plugin CVE detail page#16729
dvail merged 1 commit intomasterfrom
dv/ROX-30702-implement-cve-detail-page

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Sep 9, 2025

Description

Adds the CVE detail page in the console plugin.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Visit the security overview and click a CVE link in the table while viewing "All projects".
image
image

Update the project selector to choose an individual project. The entity tables should update to contain only entities in scope, and the "Namespace" column should disappear. Namespace filters should not be available via the dropdown.
image

@dvail
Copy link
Contributor Author

dvail commented Sep 9, 2025

@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 9, 2025

Images are ready for the commit at 40fcb78.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-726-g40fcb78b40.

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.67%. Comparing base (6fdd191) to head (40fcb78).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16729      +/-   ##
==========================================
- Coverage   48.67%   48.67%   -0.01%     
==========================================
  Files        2676     2676              
  Lines      199819   199819              
==========================================
- Hits        97264    97262       -2     
- Misses      94945    94946       +1     
- Partials     7610     7611       +1     
Flag Coverage Δ
go-unit-tests 48.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail marked this pull request as ready for review September 9, 2025 18:19
@dvail dvail requested a review from a team as a code owner September 9, 2025 18:19
Base automatically changed from dv/security-vuln-page-e2e-tests to master September 9, 2025 19:18
@dvail dvail force-pushed the dv/ROX-30702-implement-cve-detail-page branch from 9b143d6 to 40fcb78 Compare September 10, 2025 12:50
Copy link
Contributor

@sachaudh sachaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2025

@dvail: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-18-nongroovy-e2e-tests 40fcb78 link false /test ocp-4-18-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dvail dvail merged commit 7b1379b into master Sep 10, 2025
139 of 168 checks passed
@dvail dvail deleted the dv/ROX-30702-implement-cve-detail-page branch September 10, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants