ROX-30865: increase k8s client timeout > retryable-http#16835
Merged
Conversation
Fixes ROX-30865 by increasing the REST client context timeout from 8s to 10s to allow proper retry behavior when network issues occur. The retry configuration uses: - 3 retry attempts with exponential backoff (500ms to 2s) - 9s individual HTTP timeout per attempt - 10s overall context timeout (now updated from 8s) This ensures the context doesn't expire before retries can complete, addressing TestPod failures with "context deadline exceeded" errors that occurred even after the retry mechanism was introduced. Previous fixes: - Added go-retryablehttp retry client with 3 attempts - Configured exponential backoff timing - Set 9s individual request timeout Related: commit fdd6300 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
parametalol
reviewed
Sep 15, 2025
Contributor
|
Images are ready for the commit at cf7aead. To use with deploy scripts, first |
parametalol
reviewed
Sep 15, 2025
Addresses review feedback identifying the real source of 10-minute timeouts. The namespace creation retry logic was using a 10-minute timeout that exactly matched the Go test framework timeout, causing tests to hang. Changes: - Reduced defaultNamespaceCreateTimeout from 10 minutes to 2 minutes - Added better error logging when namespace creation times out - This should prevent the mysterious 10-minute hangs in LoadBalancer tests Credit: @lvalerom for identifying the actual root cause
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16835 +/- ##
=======================================
Coverage 48.97% 48.97%
=======================================
Files 2691 2691
Lines 201486 201486
=======================================
+ Hits 98674 98676 +2
+ Misses 95162 95159 -3
- Partials 7650 7651 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
Contributor
|
Caution There are some errors in your PipelineRun template.
|
janisz
commented
Sep 16, 2025
parametalol
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ROX-30865 by increasing the REST client context timeout from 8s to 10s to allow proper retry behavior when network issues occur.
The retry configuration uses:
This ensures the context doesn't expire before retries can complete, addressing TestPod failures with "context deadline exceeded" errors that occurred even after the retry mechanism was introduced.
Previous fixes:
Related:
🤖 Generated with Claude Code