Skip to content

ROX-25528: Handle quotes in PR title and Jira summary in notify GHA#16849

Merged
tommartensen merged 2 commits intomasterfrom
tm/ROX-25528-handle-quotes-in-milestone-pr-title
Sep 17, 2025
Merged

ROX-25528: Handle quotes in PR title and Jira summary in notify GHA#16849
tommartensen merged 2 commits intomasterfrom
tm/ROX-25528-handle-quotes-in-milestone-pr-title

Conversation

@tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Sep 16, 2025 •
edited
Loading

Description

https://issues.redhat.com/browse/ROX-25528

  • adds workflow dispatch for easier testing
  • fixes the Slack notification by escaping of quotes in PR titles and Jira summaries ("Notify on milestone change cannot handle quotes in issue title" is the summary for ROX-25528)

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Tested in stackrox/test-gh-actions

@tommartensen tommartensen requested a review from a team September 16, 2025 08:51
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 16, 2025 •
edited
Loading

Images are ready for the commit at 68fc227.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-785-g68fc227250.

@tommartensen tommartensen marked this pull request as ready for review September 16, 2025 09:13
@tommartensen tommartensen requested a review from a team as a code owner September 16, 2025 09:13
sourcery-ai[bot]

This comment was marked as spam.

Sign in to view

@codecov
Copy link

codecov bot commented Sep 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.96%. Comparing base (960eb0b) to head (68fc227).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16849      +/-   ##
==========================================
- Coverage   48.97%   48.96%   -0.01%     
==========================================
  Files        2690     2690              
  Lines      201445   201445              
==========================================
- Hits        98650    98647       -3     
- Misses      95144    95146       +2     
- Partials     7651     7652       +1
Flag Coverage Δ
go-unit-tests 48.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

janisz
janisz reviewed Sep 16, 2025
View reviewed changes
janisz
janisz reviewed Sep 16, 2025
View reviewed changes
@tommartensen tommartensen merged commit cdb0da7 into master Sep 17, 2025
91 checks passed
@tommartensen tommartensen deleted the tm/ROX-25528-handle-quotes-in-milestone-pr-title branch September 17, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@janisz janisz janisz approved these changes

Assignees

No one assigned

Labels

area/ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommartensen @rhacs-bot @janisz