ROX-28636: Add collector health check before network edge test#16984
Closed
ROX-28636: Add collector health check before network edge test#16984
Conversation
…ation Wait for collector to be healthy before checking collector->sensor network edges in NetworkFlowTest. This prevents test failures caused by timing issues where the test runs before collector has established proper communication with the sensor. - Add ApplicationHealth import to NetworkFlowTest - Use waitForCollectorHealthiness() before edge verification - Set 120-second timeout for collector health check - Follows same pattern as PR #16689 for AdmissionControllerTest This should resolve the flaky NetworkFlowTest failure where edges return null due to collector not being ready. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Images are ready for the commit at d20c184. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16984 +/- ##
==========================================
- Coverage 48.79% 48.78% -0.01%
==========================================
Files 2693 2693
Lines 201239 201239
==========================================
- Hits 98191 98184 -7
- Misses 95292 95297 +5
- Partials 7756 7758 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
It was already done in #16862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROX-28636: Add collector health check before network edge verification
Wait for collector to be healthy before checking collector->sensor network edges in NetworkFlowTest. This prevents test failures caused by timing issues where the test runs before collector has established proper communication with the sensor.
This should resolve the flaky NetworkFlowTest failure where edges return null due to collector not being ready.
🤖 Generated with Claude Code