Skip to content

fix: buildIndicatorFilter query for deployments#17007

Merged
janisz merged 4 commits intomasterfrom
fix-buildindicatorfilter-query
Oct 6, 2025
Merged

fix: buildIndicatorFilter query for deployments#17007
janisz merged 4 commits intomasterfrom
fix-buildindicatorfilter-query

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Sep 24, 2025

This PR changes the logic of buildIndicatorFilter to fetch only indicators for deployments instead and not filtering it in code. This should reduce amount of data returned by DB and reduce operations performed in walk function.

@janisz
Copy link
Contributor Author

janisz commented Sep 24, 2025

@janisz janisz force-pushed the fix-buildindicatorfilter-query branch from 6de3035 to 0df4e25 Compare October 2, 2025 10:10
@janisz janisz requested review from a team as code owners October 2, 2025 10:10
@janisz janisz requested review from GrimmiMeloni and removed request for a team October 2, 2025 10:10
@janisz janisz changed the base branch from use-get-by-query-fn to master October 2, 2025 10:10
@gitguardian
Copy link

gitguardian bot commented Oct 2, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@janisz janisz force-pushed the fix-buildindicatorfilter-query branch from eefa782 to 31c99ae Compare October 2, 2025 13:04
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 2, 2025

Images are ready for the commit at 79e123f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-986-g79e123f8ec.

@janisz janisz force-pushed the fix-buildindicatorfilter-query branch 2 times, most recently from 7b1318c to 40967d7 Compare October 6, 2025 12:11
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.75%. Comparing base (3e81a83) to head (79e123f).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
central/detection/lifecycle/manager_impl.go 0.00% 6 Missing ⚠️
...ntral/processindicator/datastore/datastore_impl.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17007   +/-   ##
=======================================
  Coverage   48.74%   48.75%           
=======================================
  Files        2709     2709           
  Lines      202318   202316    -2     
=======================================
+ Hits        98622    98630    +8     
+ Misses      95916    95908    -8     
+ Partials     7780     7778    -2     
Flag Coverage Δ
go-unit-tests 48.75% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

janisz added 3 commits October 6, 2025 15:54
# Conflicts:
#	central/processindicator/datastore/datastore.go
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the fix-buildindicatorfilter-query branch from 3cba7b4 to 79e123f Compare October 6, 2025 13:54
@janisz janisz added the auto-retest PRs with this label will be automatically retested if prow checks fails label Oct 6, 2025
@janisz janisz merged commit 36019e6 into master Oct 6, 2025
94 of 95 checks passed
@janisz janisz deleted the fix-buildindicatorfilter-query branch October 6, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/central auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants