fix(build): Revert "ROX-31023: arm64 support for operator images"#17106
fix(build): Revert "ROX-31023: arm64 support for operator images"#17106tommartensen merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Double-check that all CI matrix definitions and scripts no longer reference the removed
matrix.archandTARGET_ARCHvariables to avoid leftover configuration errors. - Validate that switching the operator Dockerfile base image from ubi9 to ubi8 and removing the
TARGET_ARCHargument is intentional and compatible with our current build environment. - Ensure the removal of
push_operator_imageandpush_operator_manifest_listsin scripts/ci/lib.sh does not leave any dangling invocations elsewhere in the repo.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that all CI matrix definitions and scripts no longer reference the removed `matrix.arch` and `TARGET_ARCH` variables to avoid leftover configuration errors.
- Validate that switching the operator Dockerfile base image from ubi9 to ubi8 and removing the `TARGET_ARCH` argument is intentional and compatible with our current build environment.
- Ensure the removal of `push_operator_image` and `push_operator_manifest_lists` in scripts/ci/lib.sh does not leave any dangling invocations elsewhere in the repo.
## Individual Comments
### Comment 1
<location> `operator/Dockerfile:18` </location>
<code_context>
# Cache deps before building and copying source so that we don't need to re-download as much and so that source changes
# don't invalidate our downloaded layer.
-# We're not using `go mod tidy` here because go mod tidy needs to examine _source code_ in order to find unused modules.
+# We're not using `go mod tidy` here becuase go mod tidy needs to examine _source code_ in order to find unused modules.
# There's no source code in this docker layer yet and so `go mod tidy` would empty go.mod and go.sum which is not what
# we want. If we're to COPY source before running `go mod tidy`, local docker build times would go up because any code
</code_context>
<issue_to_address>
**nitpick (typo):** Typo: 'becuase' should be 'because'.
```suggestion
# We're not using `go mod tidy` here because go mod tidy needs to examine _source code_ in order to find unused modules.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at 36c1ec7. To use with deploy scripts, first |
|
@vladbologa: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
Caution There are some errors in your PipelineRun template.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17106 +/- ##
=======================================
Coverage 48.78% 48.78%
=======================================
Files 2712 2712
Lines 202407 202407
=======================================
+ Hits 98750 98753 +3
+ Misses 95874 95870 -4
- Partials 7783 7784 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #16915 as the change is breaking all Stackrox builds.