chore(bench): image upsert benchmark#17274
Conversation
|
Images are ready for the commit at 4ebac98. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17274 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 2720 2720
Lines 203364 203364
=======================================
+ Hits 99371 99381 +10
+ Misses 96168 96160 -8
+ Partials 7825 7823 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajheflin
left a comment
There was a problem hiding this comment.
The only thing I don't love here is the overwriting of the Image IDs with IDs that are of entirely different types than we would have in a real environment. However, given it's just to test the performance when it comes to DB operations, I suppose it's fine in this case
48d4588 to
4ebac98
Compare
Description
Adding benchmarks for image upsert. Will be used to demonstrate improvements in #17200
User-facing documentation
Testing and quality
Automated testing
How I validated my change
This is only a test.