Skip to content

ROX-31173, ROX-31174: backport CVE data model id performance improvements#17339

Merged
kurlov merged 3 commits intorelease-4.9from
dashrews/backport-cve-data-model-id-fixes-31173-31174
Oct 17, 2025
Merged

ROX-31173, ROX-31174: backport CVE data model id performance improvements#17339
kurlov merged 3 commits intorelease-4.9from
dashrews/backport-cve-data-model-id-fixes-31173-31174

Conversation

@dashrews78
Copy link
Contributor

Description

backport of #17154 and #17200. I'm backporting them together because they need to go together so for the release branch it is simpler to do as 1 PR vs the 2 I used in master.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Will fire up a cluster and test this out.

@dashrews78 dashrews78 requested review from a team and janisz as code owners October 16, 2025 19:33
@github-actions github-actions bot added area/central area/ui backport PR to backport changes from master to release branch labels Oct 16, 2025
@dashrews78 dashrews78 changed the title Dashrews/backport CVE data model id fixes 31173 31174 ROX-31173, ROX-31174: backport CVE data model id performance improvements Oct 16, 2025
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at c4c0308.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.0-rc.0-6-gc4c030861f.

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 52.17391% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (50644b0) to head (c4c0308).
⚠️ Report is 5 commits behind head on release-4.9.

Files with missing lines Patch % Lines
central/risk/manager/manager.go 0.00% 14 Missing ⚠️
central/imagev2/datastore/datastore_impl.go 0.00% 4 Missing ⚠️
pkg/cve/cve.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-4.9   #17339      +/-   ##
===============================================
- Coverage        48.84%   48.84%   -0.01%     
===============================================
  Files             2717     2717              
  Lines           203231   203028     -203     
===============================================
- Hits             99266    99159     -107     
+ Misses           96149    96073      -76     
+ Partials          7816     7796      -20     
Flag Coverage Δ
go-unit-tests 48.84% <52.17%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dashrews78 dashrews78 added this to the 4.9.0-rc.1 milestone Oct 17, 2025
@kurlov kurlov merged commit ada3e37 into release-4.9 Oct 17, 2025
116 of 126 checks passed
@kurlov kurlov deleted the dashrews/backport-cve-data-model-id-fixes-31173-31174 branch October 17, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/central area/ui backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants