Skip to content

ROX-31173, ROX-31174: 4.8 backport CVE performance improvements#17351

Merged
jvdm merged 3 commits intorelease-4.8from
dashrews/backport-cve-data-model-id-fixes-31173-31174-4-8
Oct 17, 2025
Merged

ROX-31173, ROX-31174: 4.8 backport CVE performance improvements#17351
jvdm merged 3 commits intorelease-4.8from
dashrews/backport-cve-data-model-id-fixes-31173-31174-4-8

Conversation

@dashrews78
Copy link
Contributor

@dashrews78 dashrews78 commented Oct 17, 2025

Description

backport of #17154 and #17200. I'm backporting them together because they need to go together so for the release branch it is simpler to do as 1 PR vs the 2 I used in master.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@dashrews78 dashrews78 requested review from a team and janisz as code owners October 17, 2025 10:27
@github-actions github-actions bot added area/central area/ui backport PR to backport changes from master to release branch labels Oct 17, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 17, 2025

Images are ready for the commit at 81feecb.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.5-rc.0-12-g81feecb0b7.

@codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (1e3b239) to head (81feecb).

Files with missing lines Patch % Lines
central/risk/manager/manager.go 0.00% 12 Missing ⚠️
pkg/cve/cve.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-4.8   #17351      +/-   ##
===============================================
- Coverage        48.86%   48.85%   -0.01%     
===============================================
  Files             2594     2594              
  Lines           190873   190736     -137     
===============================================
- Hits             93263    93189      -74     
+ Misses           90281    90238      -43     
+ Partials          7329     7309      -20
Flag Coverage Δ
go-unit-tests 48.85% <52.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dashrews78 dashrews78 added this to the 4.8.5-rc.1 milestone Oct 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

@dashrews78: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-next-candidate-ui-e2e-tests 81feecb link false /test ocp-next-candidate-ui-e2e-tests
ci/prow/ocp-dev-preview-ui-e2e-tests 81feecb link false /test ocp-dev-preview-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jvdm jvdm merged commit 910da3d into release-4.8 Oct 17, 2025
114 of 124 checks passed
@jvdm jvdm deleted the dashrews/backport-cve-data-model-id-fixes-31173-31174-4-8 branch October 17, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvail dvail dvail approved these changes

@janisz janisz janisz approved these changes

Assignees

No one assigned

Labels

area/central area/ui backport PR to backport changes from master to release branch

Projects

None yet

Milestone

4.8.5-rc.1

Development

Successfully merging this pull request may close these issues.

5 participants

@dashrews78 @rhacs-bot @dvail @janisz @jvdm