Skip to content

chore: move image_prefetcher_prebuilt_await in nongroovy case#17372

Merged
porridge merged 1 commit intomasterfrom
porridge/await-prefetcher-nongroovy
Oct 22, 2025
Merged

chore: move image_prefetcher_prebuilt_await in nongroovy case#17372
porridge merged 1 commit intomasterfrom
porridge/await-prefetcher-nongroovy

Conversation

@porridge
Copy link
Contributor

@porridge porridge commented Oct 20, 2025

Description

Following up on #17327 to make sure awaiting happens:

  • as late as possible, to increase parallelism
  • only once per test job, to avoid duplication of prefetcher metrics

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

CI

@porridge porridge requested a review from vikin91 October 20, 2025 10:26
@porridge porridge mentioned this pull request Oct 20, 2025
Merged
9 tasks
sourcery-ai[bot]
sourcery-ai bot reviewed Oct 20, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

vikin91
vikin91 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping with this!

@codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.80%. Comparing base (0eafc13) to head (4eb783d).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17372   +/-   ##
=======================================
  Coverage   48.80%   48.80%           
=======================================
  Files        2724     2724           
  Lines      203154   203154           
=======================================
  Hits        99157    99157           
+ Misses      96211    96210    -1     
- Partials     7786     7787    +1
Flag Coverage Δ
go-unit-tests 48.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 21, 2025

Images are ready for the commit at 4eb783d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-65-g4eb783d2be.

@porridge
Copy link
Contributor Author

porridge commented Oct 21, 2025

/retest

@porridge porridge merged commit 5b20353 into master Oct 22, 2025
139 of 166 checks passed
@porridge porridge deleted the porridge/await-prefetcher-nongroovy branch October 22, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@vikin91 vikin91 vikin91 approved these changes

Assignees

No one assigned

Labels

ai-review area/ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@porridge @rhacs-bot @vikin91