ROX-31321: do not write component score to risk#17422
Merged
dashrews78 merged 3 commits intomasterfrom Nov 13, 2025
Merged
Conversation
Contributor
|
Images are ready for the commit at d4306ca. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17422 +/- ##
==========================================
- Coverage 49.01% 49.01% -0.01%
==========================================
Files 2729 2729
Lines 201599 201579 -20
==========================================
- Hits 98821 98806 -15
+ Misses 95045 95036 -9
- Partials 7733 7737 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
62e4131 to
44e5669
Compare
Contributor
Author
|
/retest |
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Since component risk entries will no longer be inserted, update or remove any pruning logic that scans or relies on those records to avoid needless database scans.
- Add a one-time migration or cleanup job to purge existing image/node component risk records so the risk table state stays consistent after this change.
- Now that oldScore retrieval and its FlattenCVEData branches are unused, you can simplify the manager by removing that dead code.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since component risk entries will no longer be inserted, update or remove any pruning logic that scans or relies on those records to avoid needless database scans.
- Add a one-time migration or cleanup job to purge existing image/node component risk records so the risk table state stays consistent after this change.
- Now that oldScore retrieval and its FlattenCVEData branches are unused, you can simplify the manager by removing that dead code.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
44e5669 to
3a57781
Compare
3a57781 to
d4306ca
Compare
clickboo
approved these changes
Nov 13, 2025
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We calculate the component risk and store it in the risk table. There are many components so this is fairly expensive. However, we never access those items in the risk store (we literally only pull components out of risk to prune them). So there is no reason to store them. That is just unnecessary overhead on the database and on central.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI testing, unit testing, clicking about the UI.