Description

Re-enable detection of /bin/sh, /bin/date, and /bin/sleep processes in TestPod and TestContainerInstances by removing TODO(ROX-31331) workarounds.

Problem

Tests TestPod and TestContainerInstances were not checking for /bin/sh, /bin/date, and /bin/sleep processes from the Ubuntu container due to unreliable Collector process detection (ROX-31331). The tests had TODO comments indicating these processes should be re-enabled once the underlying issue was resolved.

Why it was failing before

We created ROX-31331, because it was easy to say that if something is missing in Central, then most probably the Collector is not reporting something. The faith in Sensor was too strong, because it turned out that Sensor was loosing selected data in the test run because it was restarted shortly before the TestPod and TestContainerInstances were triggered.
The issue of Sensor not being ready for test was fixed in #17502.

Changes

Removed TODO(ROX-31331) comments and re-enabled full process detection:

tests/container_instances_test.go:

• Changed requiredSecondContainer from []string{"/bin/sh"}
• To: []string{"/bin/sh", "/bin/date", "/bin/sleep"}

tests/pods_test.go:

• Changed requiredProcesses from []string{"/usr/sbin/nginx"}
• To: []string{"/usr/sbin/nginx", "/bin/sh", "/bin/date", "/bin/sleep"}

Before vs After

Before:

// TODO(ROX-31331): Collector cannot reliably detect /bin/sh /bin/date or /bin/sleep
requiredProcesses := []string{"/usr/sbin/nginx"} // Only checking nginx

After:

requiredProcesses := []string{"/usr/sbin/nginx", "/bin/sh", "/bin/date", "/bin/sleep"}

User-facing documentation

• CHANGELOG.md is updated OR update is not needed
• documentation PR is created and is linked above OR is not needed

Testing and quality

• the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
• CI results are inspected

Automated testing

• added unit tests
• added e2e tests
• added regression tests
• added compatibility tests
• modified existing tests

How I validated my change

• I run gke-nongroovy-e2e-tests and ocp-4-19-nongroovy-e2e-tests in CI 10 times each, and manually checked the results by making sure that TestPod and TestContainerInstances are not failing.