Skip to content

ROX-31770: Import required CSS for FeedbackModal styling#18008

Merged
sachaudh merged 1 commit intodv/ROX-28622-pf-6from
saif/ROX-31770-fix-share-feedback-modal
Dec 9, 2025
Merged

ROX-31770: Import required CSS for FeedbackModal styling#18008
sachaudh merged 1 commit intodv/ROX-28622-pf-6from
saif/ROX-31770-fix-share-feedback-modal

Conversation

@sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Dec 2, 2025

Description

This PR fixes styling issues related to the "Share Feedback Modal".

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Before v5

Screenshot 2025-12-01 at 7 21 31 PM

After v5 but before PR fixes

Screenshot 2025-12-01 at 7 22 44 PM

After PR fixes

Screenshot 2025-12-01 at 7 17 37 PM

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sachaudh sachaudh force-pushed the saif/ROX-31770-fix-share-feedback-modal branch from 1963578 to b0361e7 Compare December 2, 2025 03:35
@sachaudh sachaudh changed the base branch from dv/ROX-31766-fix-logos-and-login-page to saif/ROX-31771-fix-my-profile December 2, 2025 03:35
@sachaudh sachaudh marked this pull request as ready for review December 2, 2025 03:38
@sachaudh sachaudh requested a review from a team as a code owner December 2, 2025 03:38
@sachaudh sachaudh requested a review from dvail December 2, 2025 03:38
@sachaudh sachaudh changed the title fix(ui): import required CSS for FeedbackModal styling ROX-31770: Import required CSS for FeedbackModal styling Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dv/ROX-28622-pf-6@2dcf1e3). Learn more about missing BASE report.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##             dv/ROX-28622-pf-6   #18008   +/-   ##
====================================================
  Coverage                     ?   49.35%           
====================================================
  Files                        ?     2699           
  Lines                        ?   198960           
  Branches                     ?        0           
====================================================
  Hits                         ?    98190           
  Misses                       ?    93151           
  Partials                     ?     7619
Flag Coverage Δ
go-unit-tests 49.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sachaudh sachaudh force-pushed the saif/ROX-31771-fix-my-profile branch from 403d48d to 69d9c49 Compare December 3, 2025 18:27
@sachaudh sachaudh requested a review from a team as a code owner December 3, 2025 18:27
@sachaudh sachaudh force-pushed the saif/ROX-31770-fix-share-feedback-modal branch from b0361e7 to da76cd0 Compare December 4, 2025 01:47
dvail
dvail approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@dvail dvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm assuming the removal of "Support case" is due to changes in the react-user-feedback dependency?

@sachaudh
Copy link
Contributor Author

sachaudh commented Dec 9, 2025

LGTM - I'm assuming the removal of "Support case" is due to changes in the react-user-feedback dependency?

Oh no, the "Support case" option only shows up for Red Hat customers. It should be hidden for StackRox-branded deployments. I was also curious why it didn't show up until I saw the logic in AcsFeedbackModal.tsx:94-98

onOpenSupportCase={
    type === 'RHACS_BRANDING'
        ? 'https://access.redhat.com/support/cases/#/case/new/open-case?caseCreate=true'
        : ''
}

@sachaudh sachaudh force-pushed the saif/ROX-31770-fix-share-feedback-modal branch from da76cd0 to d58c163 Compare December 9, 2025 02:21
Base automatically changed from saif/ROX-31771-fix-my-profile to dv/ROX-28622-pf-6 December 9, 2025 21:27
@sachaudh
fix(ui): import required CSS for FeedbackModal styling
5f2f4c9 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
@sachaudh sachaudh force-pushed the saif/ROX-31770-fix-share-feedback-modal branch from d58c163 to 5f2f4c9 Compare December 9, 2025 21:30
@sachaudh sachaudh merged commit b8c6f38 into dv/ROX-28622-pf-6 Dec 9, 2025
53 of 58 checks passed
@sachaudh sachaudh deleted the saif/ROX-31770-fix-share-feedback-modal branch December 9, 2025 21:30
dvail pushed a commit that referenced this pull request Dec 9, 2025
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
a25b6de 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Jan 7, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
f312119 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Jan 30, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
78d4305 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 3, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
710ca74 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 6, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
cededbd 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 10, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
9378f7a 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 11, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
f132888 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 12, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
794cb58 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 13, 2026
@sachaudh @dvail
ROX-31770: Import required CSS for FeedbackModal styling (#18008)
f819f8b 
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvail dvail dvail approved these changes

Assignees

No one assigned

Labels

area/ui pf-v6-upgrade

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sachaudh @dvail