Skip to content

ROX-32114: add base image column to images#18063

Merged
daynewlee merged 9 commits intomasterfrom
yli3/baseImageMappingDs
Dec 19, 2025
Merged

ROX-32114: add base image column to images#18063
daynewlee merged 9 commits intomasterfrom
yli3/baseImageMappingDs

Conversation

@daynewlee
Copy link
Contributor

@daynewlee daynewlee commented Dec 4, 2025 •
edited
Loading

Description

In images_v2 table, we should track whether deployed/watched images are matched with base images.
Also changed in images table as backup
The base image info should be saved in serialized column

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Will be added

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Dec 4, 2025 •
edited
Loading

Images are ready for the commit at c299f62.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-662-gc299f6208a.

@daynewlee daynewlee changed the title Yli3/base image mapping ds ROX-32114: add base image mapping to datastore Dec 4, 2025
@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch from 2e54cd2 to f1da34b Compare December 4, 2025 21:56
daynewlee
daynewlee commented Dec 8, 2025
View reviewed changes
@daynewlee daynewlee marked this pull request as ready for review December 8, 2025 17:07
@daynewlee daynewlee requested review from a team as code owners December 8, 2025 17:07
@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch from 21002f0 to 638821e Compare December 8, 2025 17:07
@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch from 638821e to 962a5da Compare December 9, 2025 04:27
daynewlee
daynewlee commented Dec 9, 2025
View reviewed changes
@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch 4 times, most recently from aa7ad47 to f981e5e Compare December 10, 2025 04:54
@codecov
Copy link

codecov bot commented Dec 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 16.07143% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.91%. Comparing base (d20c8fc) to head (c299f62).

Files with missing lines Patch % Lines
central/graphql/resolvers/generated.go 13.46% 45 Missing ⚠️
...al/graphql/resolvers/image_components_utilities.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #18063      +/-   ##
==========================================
- Coverage   48.92%   48.91%   -0.02%     
==========================================
  Files        2619     2619              
  Lines      197514   197568      +54     
==========================================
+ Hits        96631    96632       +1     
- Misses      93504    93557      +53     
  Partials     7379     7379
Flag Coverage Δ
go-unit-tests 48.91% <16.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch from f981e5e to 43c3818 Compare December 10, 2025 17:48
@daynewlee daynewlee changed the title ROX-32114: add base image mapping to datastore ROX-32114: add base image column to images Dec 12, 2025
c-du
c-du reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

@c-du c-du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to add a test case somewhere? I saw you add fixtures but not test.

@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch 2 times, most recently from a1b6e68 to 2b3eabb Compare December 18, 2025 15:07
@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch from e0cba02 to e3d6ea7 Compare December 18, 2025 15:54
@daynewlee daynewlee requested a review from c-du December 18, 2025 18:42
@daynewlee daynewlee force-pushed the yli3/baseImageMappingDs branch from b437de0 to c299f62 Compare December 18, 2025 20:37
@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

@daynewlee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests c299f62 link false /test ocp-4-12-qa-e2e-tests
ci/prow/gke-ui-e2e-tests c299f62 link true /test gke-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@daynewlee daynewlee merged commit daf363c into master Dec 19, 2025
94 of 97 checks passed
@daynewlee daynewlee deleted the yli3/baseImageMappingDs branch December 19, 2025 05:20
@guzalv guzalv mentioned this pull request Dec 29, 2025
Merged
4 tasks
@c-du c-du mentioned this pull request Jan 6, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-du c-du c-du approved these changes

@jvdm jvdm Awaiting requested review from jvdm

@ksurabhi91 ksurabhi91 Awaiting requested review from ksurabhi91

@BradLugo BradLugo Awaiting requested review from BradLugo

@charmik-redhat charmik-redhat Awaiting requested review from charmik-redhat

@dcaravel dcaravel Awaiting requested review from dcaravel

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daynewlee @rhacs-bot @c-du